This is an archive of the discontinued LLVM Phabricator instance.

Adding avx512 (shuf,sqrt{ss|sd},rsqrt ) builtin to clang
ClosedPublic

Authored by m_zuckerman on Apr 9 2016, 8:39 AM.

Details

Summary

Was Close by commit to revision 266048

Diff Detail

Event Timeline

m_zuckerman updated this revision to Diff 53133.Apr 9 2016, 8:39 AM
m_zuckerman retitled this revision from to Adding avx512 (shuf,sqrt{ss|sd},rsqrt ) builtin to clang .
m_zuckerman updated this object.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: llvm-commits.
AsafBadouh added inline comments.Apr 10 2016, 8:28 AM
lib/Headers/avx512fintrin.h
4287

last parameter should be __R

test/CodeGen/avx512f-builtins.c
2581

please add the suffix of the intrinsic

2587

please add the suffix of the intrinsic

test/CodeGen/avx512vl-builtins.c
4302

please add the suffix the intrinsic

4302

there is no rounding mode in shuffle.
I think you want to use the enum you declared in avx512fintrin.h (_MM_PERM_*)

m_zuckerman marked 2 inline comments as done.
AsafBadouh accepted this revision.Apr 11 2016, 8:12 AM
AsafBadouh edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 11 2016, 8:12 AM
m_zuckerman closed this revision.Apr 12 2016, 1:16 AM
m_zuckerman updated this object.
m_zuckerman edited edge metadata.