This is an archive of the discontinued LLVM Phabricator instance.

Differential D18761

[mips] Enable IAS by default for 32-bit MIPS targets (O32).
ClosedPublic

Authored by dsanders on Apr 4 2016, 9:31 AM.

Details

Reviewers
vkalintiris
Summary

The MIPS IAS can now pass 'ninja check-all' and recurse now that the immediates
are all range checked properly.

Unfortunately we can't enable it by default for 64-bit targets yet since the N32
ABI is still very buggy and this also means we can't enable it for N64 either
because we can't distinguish between N32 and N64 in the relevant code.

Depends on D18753

Diff Detail

Event Timeline

dsanders updated this revision to Diff 52567.Apr 4 2016, 9:31 AM
dsanders retitled this revision from to [mips] Enable IAS by default for 32-bit MIPS targets (O32)..
dsanders updated this object.
dsanders added a reviewer: vkalintiris.
dsanders added a parent revision: D18753: [mips][sanitizer_common] Don't use `ld` in internal_clone() on 32-bit MIPS..
dsanders added a subscriber: cfe-commits.
dsanders added a child revision: D18759: [mips] Enable IAS by default for 32-bit MIPS targets (O32)..Apr 4 2016, 9:33 AM
vkalintiris accepted this revision.Apr 7 2016, 2:55 AM
vkalintiris edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Apr 7 2016, 2:55 AM
dsanders closed this revision.Jun 7 2016, 5:47 AM

This has already been committed. I'm not sure why it didn't auto-close.

Revision Contents

PathSize
lib/
Driver/
2 lines

Diff 52567

lib/Driver/ToolChains.cpp

Show First 20 Lines • Show All 2,390 Lines • ▼ Show 20 Linesbool Generic_GCC::IsIntegratedAssemblerDefault() const {
case llvm::Triple::bpfel: case llvm::Triple::bpfel:
case llvm::Triple::bpfeb: case llvm::Triple::bpfeb:
case llvm::Triple::thumb: case llvm::Triple::thumb:
case llvm::Triple::thumbeb: case llvm::Triple::thumbeb:
case llvm::Triple::ppc: case llvm::Triple::ppc:
case llvm::Triple::ppc64: case llvm::Triple::ppc64:
case llvm::Triple::ppc64le: case llvm::Triple::ppc64le:
case llvm::Triple::systemz: case llvm::Triple::systemz:
case llvm::Triple::mips:
case llvm::Triple::mipsel:
return true; return true;
default: default:
return false; return false;
} }
} }
/// \brief Helper to add the variant paths of a libstdc++ installation. /// \brief Helper to add the variant paths of a libstdc++ installation.
bool Generic_GCC::addLibStdCXXIncludePaths( bool Generic_GCC::addLibStdCXXIncludePaths(
▲ Show 20 Lines • Show All 2,171 Lines • Show Last 20 Lines