This is an archive of the discontinued LLVM Phabricator instance.

Make sure to update Target arch if environment changed
ClosedPublic

Authored by fjricci on Mar 30 2016, 4:31 PM.

Reviewers

Commits

Summary

Fixes "target list" for non-android linux platforms (ie gnu, gnueabi)

fjricci retitled this revision from to Make sure to update Target arch if environment changed.

fjricci updated this object.

fjricci added subscribers: sas, lldb-commits.

clayborg edited edge metadata.

This revision is now accepted and ready to land.Mar 30 2016, 4:35 PM

Looks good but I don't understand why android is working while other linux platforms isn't.

android is detected from the ELF, so we can get around using the gdb-remote info.

Committed as r265419.

Path

Size

source/

Target/

2 lines

Show First 20 Lines • Show All 1,295 Lines • ▼ Show 20 Lines	if (!missing_local_arch)

m_arch.PiecewiseTripleCompare(other,		m_arch.PiecewiseTripleCompare(other,
arch_changed,		arch_changed,
vendor_changed,		vendor_changed,
os_changed,		os_changed,
os_ver_changed,		os_ver_changed,
env_changed);		env_changed);

if (!arch_changed && !vendor_changed && !os_changed)		if (!arch_changed && !vendor_changed && !os_changed && !env_changed)
replace_local_arch = false;		replace_local_arch = false;
}		}
}		}
}		}

if (compatible_local_arch \|\| missing_local_arch)		if (compatible_local_arch \|\| missing_local_arch)
{		{
// If we haven't got a valid arch spec, or the architectures are compatible		// If we haven't got a valid arch spec, or the architectures are compatible
▲ Show 20 Lines • Show All 2,941 Lines • Show Last 20 Lines