Page MenuHomePhabricator

llvm-readobj: Print GNU style program headers
ClosedPublic

Authored by khemant on Mar 22 2016, 1:07 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

khemant updated this revision to Diff 51328.Mar 22 2016, 1:07 PM
khemant retitled this revision from to llvm-readobj: Print GNU style program headers.
khemant updated this object.
khemant added reviewers: echristo, rafael.
khemant set the repository for this revision to rL LLVM.
khemant added subscribers: echristo, rafael, llvm-commits.

test/tools/llvm-readobj/Inputs/phdrs-elf.exe-* files are checked in as Binary as they are fully formed executables. They also have sufficient mix of program headers which have TLS sections in permissible segments and some extra non PT_LOAD segments.

test/tools/llvm-readobj/gnu-phdrs.test
1 ↗(On Diff #51328)

Forgot to add the source used to compile the binary. Will add it in a new patch.

khemant updated this revision to Diff 51331.Mar 22 2016, 1:17 PM

Updated test.

khemant marked an inline comment as done.Mar 22 2016, 1:17 PM
echristo accepted this revision.Mar 24 2016, 1:01 PM
echristo edited edge metadata.

Now that the general structure is there as long as you're following it I'm fine with anything you fill in to be post-commit reviewed.

Thanks!

-eric

This revision is now accepted and ready to land.Mar 24 2016, 1:01 PM
This revision was automatically updated to reflect the committed changes.