Index: cppcoreguidelines-pro-type-member-init-delayed.cpp =================================================================== --- cppcoreguidelines-pro-type-member-init-delayed.cpp +++ cppcoreguidelines-pro-type-member-init-delayed.cpp @@ -0,0 +1,32 @@ +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-member-init %t -- -- -fdelayed-template-parsing + +template +struct PositiveFieldBeforeConstructor { + PositiveFieldBeforeConstructor() {} + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor does not initialize these built-in/pointer fields: F, G, H + int F; + bool G /* with comment */; + int *H; +}; +// Explicit instantiation. +template class PositiveFieldBeforeConstructor; + +template +struct PositiveFieldAfterConstructor { + PositiveFieldAfterConstructor() {} + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor does not initialize these built-in/pointer fields: F, G, H + int F; + bool G /* with comment */; + int *H; +}; +// Explicit instantiation. +template class PositiveFieldAfterConstructor; + +// This declaration isn't used and won't be parsed 'delayed-template-parsing'. +// The body of the declaration is 'null' and may cause crash if not handled +// properly by checkers. +template +struct UnusedDelayedConstructor { + UnusedDelayedConstructor() {} + int F; +}; Index: cppcoreguidelines/ProTypeMemberInitCheck.cpp =================================================================== --- cppcoreguidelines/ProTypeMemberInitCheck.cpp +++ cppcoreguidelines/ProTypeMemberInitCheck.cpp @@ -179,6 +179,11 @@ const auto *Ctor = Result.Nodes.getNodeAs("ctor"); const auto &MemberFields = Ctor->getParent()->fields(); + // Skip declarations delayed by late template parsing without a body. + const Stmt *Body = Ctor->getBody(); + if (!Body) + return; + SmallPtrSet FieldsToInit; fieldsRequiringInit(MemberFields, FieldsToInit); if (FieldsToInit.empty()) @@ -193,8 +198,8 @@ continue; FieldsToInit.erase(Init->getMember()); } - removeFieldsInitializedInBody(*Ctor->getBody(), *Result.Context, - FieldsToInit); + removeFieldsInitializedInBody(*Body, *Result.Context, FieldsToInit); + if (FieldsToInit.empty()) return; Index: modernize-redundant-void-arg-delayed.cpp =================================================================== --- modernize-redundant-void-arg-delayed.cpp +++ modernize-redundant-void-arg-delayed.cpp @@ -0,0 +1,28 @@ +// RUN: %check_clang_tidy %s modernize-redundant-void-arg %t -- -- -fdelayed-template-parsing + +int foo(void) { +// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: redundant void argument list in function definition [modernize-redundant-void-arg] +// CHECK-FIXES: {{^}}int foo() {{{$}} + return 0; +} + +template +struct MyFoo { + int foo(void) { +// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant void argument list in function definition [modernize-redundant-void-arg] +// CHECK-FIXES: {{^}} int foo() {{{$}} + return 0; + } +}; +// Explicit instantiation. +template class MyFoo; + +template +struct MyBar { + // This declaration isn't instantiated and won't be parsed 'delayed-template-parsing'. + int foo(void) { +// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant void argument list in function definition [modernize-redundant-void-arg] +// CHECK-FIXES: {{^}} int foo() {{{$}} + return 0; + } +}; Index: modernize/RedundantVoidArgCheck.cpp =================================================================== --- modernize/RedundantVoidArgCheck.cpp +++ modernize/RedundantVoidArgCheck.cpp @@ -102,13 +102,11 @@ void RedundantVoidArgCheck::processFunctionDecl( const MatchFinder::MatchResult &Result, const FunctionDecl *Function) { - SourceLocation Start = Function->getLocStart(); if (Function->isThisDeclarationADefinition()) { - SourceLocation End; - if (Function->hasBody()) - End = Function->getBody()->getLocStart().getLocWithOffset(-1); - else - End = Function->getLocEnd(); + const Stmt *Body = Function->getBody(); + SourceLocation Start = Function->getLocStart(); + SourceLocation End = Body ? Body->getLocStart().getLocWithOffset(-1) : + Function->getLocEnd(); removeVoidArgumentTokens(Result, SourceRange(Start, End), "function definition"); } else {