Index: lib/Transforms/InstCombine/InstCombineCasts.cpp =================================================================== --- lib/Transforms/InstCombine/InstCombineCasts.cpp +++ lib/Transforms/InstCombine/InstCombineCasts.cpp @@ -976,15 +976,27 @@ // (x ashr x, 31 -> all ones if negative // (x >s -1) ? -1 : 0 -> not (ashr x, 31) -> all ones if positive if ((Pred == ICmpInst::ICMP_SLT && Op1C->isNullValue()) || - (Pred == ICmpInst::ICMP_SGT && Op1C->isAllOnesValue())) { + (Pred == ICmpInst::ICMP_SGT && Op1C->isAllOnesValue()) || + // The following comparisons should only be present for vectors. + // For scalar integers, the comparison should be canonicalized to one of + // the above forms. We don't do that canonicalization for vectors + // because vector ISAs may not have a full range of comparison + // operators. This cmp+sext transform, however, will simplify the IR, so + // we always do it. + // + // (x <=s -1) ? -1 : 0 -> ashr x, 31 -> all ones if negative + // (x >=s 0) ? -1 : 0 -> not (ashr x, 31) -> all ones if positive + (Pred == ICmpInst::ICMP_SLE && Op1C->isAllOnesValue()) || + (Pred == ICmpInst::ICMP_SGE && Op1C->isNullValue())) { Value *Sh = ConstantInt::get(Op0->getType(), Op0->getType()->getScalarSizeInBits()-1); Value *In = Builder->CreateAShr(Op0, Sh, Op0->getName()+".lobit"); if (In->getType() != CI.getType()) In = Builder->CreateIntCast(In, CI.getType(), true/*SExt*/); - if (Pred == ICmpInst::ICMP_SGT) + // Invert the sign bit if the comparison was checking for 'is positive'. + if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) In = Builder->CreateNot(In, In->getName()+".not"); return replaceInstUsesWith(CI, In); } Index: test/Transforms/InstCombine/vec_sext.ll =================================================================== --- test/Transforms/InstCombine/vec_sext.ll +++ test/Transforms/InstCombine/vec_sext.ll @@ -43,3 +43,31 @@ ; CHECK: and <4 x i32> %b.lobit.not, %sub ; CHECK: or <4 x i32> %0, %1 } + +;;; PR26701: https://llvm.org/bugs/show_bug.cgi?id=26701 + +; Signed-less-than-or-equal to -1 is the same operation as above: smear the sign bit. + +define <2 x i32> @is_negative(<2 x i32> %a) { + %cmp = icmp sle <2 x i32> %a, + %sext = sext <2 x i1> %cmp to <2 x i32> + ret <2 x i32> %sext + +; CHECK-LABEL: @is_negative( +; CHECK-NEXT: ashr <2 x i32> %a, +; CHECK-NEXT: ret <2 x i32> +} + +; Signed-greater-than-or-equal to 0 is 'not' of the same operation as above. + +define <2 x i32> @is_positive(<2 x i32> %a) { + %cmp = icmp sge <2 x i32> %a, zeroinitializer + %sext = sext <2 x i1> %cmp to <2 x i32> + ret <2 x i32> %sext + +; CHECK-LABEL: @is_positive( +; CHECK-NEXT: [[SHIFT:%[a-zA-Z0-9.]+]] = ashr <2 x i32> %a, +; CHECK-NEXT: xor <2 x i32> [[SHIFT]], +; CHECK-NEXT: ret <2 x i32> +} +