Page MenuHomePhabricator

Check if LLVM_PREFIX is defined before using it.
ClosedPublic

Authored by chaoren on Mar 1 2016, 3:00 PM.

Details

Summary

LLVM_PREFIX could be undefined if CMAKE_INSTALL_PREFIX were set to empty.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren updated this revision to Diff 49553.Mar 1 2016, 3:00 PM
chaoren retitled this revision from to Check if LLVM_PREFIX is defined before using it..
chaoren updated this object.
chaoren added reviewers: kparzysz, bkramer.
chaoren added a subscriber: cfe-commits.
kparzysz edited edge metadata.Mar 3 2016, 6:30 AM

This seemed fine to me, but at the second thought, the lines 2610-2613 in the original should be removed.

This seemed fine to me, but at the second thought, the lines 2610-2613 in the original should be removed.

chandlerc edited edge metadata.Mar 3 2016, 2:19 PM

This seemed fine to me, but at the second thought, the lines 2610-2613 in the original should be removed.

I agree. I think using LLVM_PREFIX here in any capacity is incorrect.

chaoren edited edge metadata.

Remove usage of LLVM_PREFIX altogether.

This revision was automatically updated to reflect the committed changes.