Page MenuHomePhabricator

Make getModRefInfo more consistent for loads/stores and cmpxchg/atomicrmw
Needs ReviewPublic

Authored by george.burgess.iv on Feb 25 2016, 5:58 PM.

Details

Reviewers
eli.friedman
Summary

Hi!

When looking through lib/Analysis/AliasAnalysis.cpp, I noticed that we always answer conservatively for volatile loads/stores, but we don't necessarily do this for cmpxchg/atomicrmw. This seems inconsistent to me, so I'd like to know if it was intentional. If not, here's a patch to fix it. :)

The change is fairly insignificant/I can't get it to fire with a lit test, so no test is included. If we'd like one, I'm happy to see what I can do with gtest.

Diff Detail

Event Timeline

george.burgess.iv retitled this revision from to Make getModRefInfo more consistent for loads/stores and cmpxchg/atomicrmw.
george.burgess.iv updated this object.
george.burgess.iv added a reviewer: eli.friedman.
george.burgess.iv added a subscriber: llvm-commits.