Page MenuHomePhabricator

[ELF][MIPS] Add STO_MIPS_PLT flag to the symbols require pointer equality
ClosedPublic

Authored by atanasyan on Feb 24 2016, 9:16 PM.

Details

Summary

On MIPS we need to mark symbol which has a PLT entry and requires pointer equality by STO_MIPS_PLT flag. That is necessary to help dynamic linker distinguish such symbols and MIPS lazy-binding stubs.

https://sourceware.org/ml/binutils/2008-07/txt00000.txt

Diff Detail

Repository
rL LLVM

Event Timeline

atanasyan updated this revision to Diff 49006.Feb 24 2016, 9:16 PM
atanasyan retitled this revision from to [ELF][MIPS] Add STO_MIPS_PLT flag to the symbols require pointer equality.
atanasyan updated this object.
atanasyan added reviewers: ruiu, rafael.
atanasyan set the repository for this revision to rL LLVM.
atanasyan added a project: lld.
atanasyan added a subscriber: llvm-commits.
rafael accepted this revision.Feb 25 2016, 6:31 AM
rafael edited edge metadata.

LGTM, but please consider updating llvm-readobj to print STO_MIPS_PLT instead of 8.

This revision is now accepted and ready to land.Feb 25 2016, 6:31 AM
This revision was automatically updated to reflect the committed changes.
ruiu edited edge metadata.Feb 25 2016, 11:15 AM

LGTM

lld/trunk/ELF/OutputSections.cpp
1519

I think you can remove "ELF::"