Page MenuHomePhabricator

Support arbitrary address space for intrinsics

Authored by delena on Feb 22 2016, 12:39 AM.



This is an alternative proposal for supporting address space in intrinsics. It's applicable for any intrinsic, not only masked-load-store.
Related to

I this proposal I add non-zero address space suffix to intrinsic name. The original name looks like
The same name with address space 1 :

(I did not update documentation. I'll do this if the proposed change looks reasonable for reviewers ).

Diff Detail

Event Timeline

delena updated this revision to Diff 48653.Feb 22 2016, 12:39 AM
delena retitled this revision from to Support arbitrary address space for intrinsics.
delena updated this object.
delena added reviewers: apilipenko, reames, Ayal, arsenm, pjcoup.
delena set the repository for this revision to rL LLVM.
delena added a subscriber: llvm-commits.
apilipenko edited edge metadata.Feb 24 2016, 7:45 AM

Given the fact that you introduce a generic mangling scheme other intrinsics might benefit from I suggest you bringing this up on llvm-dev for a wider discussion. I didn't review the code thoroughly since we haven't yet agreed on the scheme.

reames requested changes to this revision.Mar 9 2016, 12:11 PM
reames edited edge metadata.

Marking as request changes to get it off my queue. I believe we've agreed to abandon this approach and possibly consider forward references instead.

This revision now requires changes to proceed.Mar 9 2016, 12:11 PM
delena abandoned this revision.Mar 9 2016, 10:27 PM