Index: zorg/buildbot/builders/ClangAndLLDBuilder.py =================================================================== --- zorg/buildbot/builders/ClangAndLLDBuilder.py +++ zorg/buildbot/builders/ClangAndLLDBuilder.py @@ -101,16 +101,20 @@ if isMSVC: options = [] if extraCompilerOptions: + assert isinstance(extraCompilerOptions, list) options += extraCompilerOptions if buildWithSanitizerOptions: + assert isinstance(buildWithSanitizerOptions, list) options += buildWithSanitizerOptions lit_args = ["-v"] if extraLitArgs: + assert isinstance(extraLitArgs, list) lit_args += extraLitArgs - lit_args_str = "-DLLVM_LIT_ARGS=\"%s\"" % (" ".join(lit_args)) + lit_args = ["-DLLVM_LIT_ARGS=\"%s\"" % " ".join(lit_args)] + cmakeCommand = [ "cmake", "-DCMAKE_BUILD_TYPE=Release", @@ -122,12 +126,13 @@ "-DCMAKE_CXX_COMPILER=clang++" ] if triple: - cmakeCommand += [ - "-DLLVM_DEFAULT_TARGET_TRIPLE=%s" % triple - ] + assert isinstance(triple, str) + cmakeCommand += ["-DLLVM_DEFAULT_TARGET_TRIPLE=%s" % triple] if extraCmakeOptions: - assert not any(a.startswith('-DLLVM_LIT_ARGS=') for a in extraCmakeOptions), "Please use extraLitArgs for LIT arguments instead of defining them in extraCmakeOptions." + assert isinstance(extraCmakeOptions, list) + assert not any(a.startswith('-DLLVM_LIT_ARGS=') for a in extraCmakeOptions), \ + "Please use extraLitArgs for LIT arguments instead of defining them in extraCmakeOptions." cmakeCommand += extraCmakeOptions if not isMSVC: @@ -135,9 +140,9 @@ "-DCMAKE_C_FLAGS=\"%s\"" % (" ".join(options)), "-DCMAKE_CXX_FLAGS=\"-std=c++11 %s\"" % (" ".join(options)), ] - cmakeCommand += lit_args_str + cmakeCommand += lit_args cmakeCommand += [ - "-G", "Ninja", + "-GNinja", "../%s" % llvm_srcdir ]