This is an archive of the discontinued LLVM Phabricator instance.

libclang python bindings: Fix for bug 26394
ClosedPublic

Authored by jbcoe on Feb 12 2016, 4:07 PM.

Reviewers

Commits

Summary

https://llvm.org/bugs/show_bug.cgi?id=26394 reports that clang's python bindings tests are failing.

I can confirm that the bug exists and that the proposed fix is good.

jbcoe retitled this revision from to libclang python bindings: Fix for bug 26394.

jbcoe updated this object.

jbcoe set the repository for this revision to rL LLVM.

Has anyone had a chance to look at this yet? Python-bindings tests have been failing for a while without this fix.

Yes, I've seen that python tests segfaulted too, never had time to investigate it though.

LGTM, great work!

This revision is now accepted and ready to land.Mar 8 2016, 1:56 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

bindings/

python/

clang/

2 lines

Show First 20 Lines • Show All 2,377 Lines • ▼ Show 20 Lines	class TranslationUnit(ClangObject):

def __init__(self, ptr, index):		def __init__(self, ptr, index):
"""Create a TranslationUnit instance.		"""Create a TranslationUnit instance.

TranslationUnits should be created using one of the from_* @classmethod		TranslationUnits should be created using one of the from_* @classmethod
functions above. __init__ is only called internally.		functions above. __init__ is only called internally.
"""		"""
assert isinstance(index, Index)		assert isinstance(index, Index)
		self.index = index
ClangObject.__init__(self, ptr)		ClangObject.__init__(self, ptr)

def __del__(self):		def __del__(self):
conf.lib.clang_disposeTranslationUnit(self)		conf.lib.clang_disposeTranslationUnit(self)

@property		@property
def cursor(self):		def cursor(self):
"""Retrieve the cursor that represents the given translation unit."""		"""Retrieve the cursor that represents the given translation unit."""
▲ Show 20 Lines • Show All 1,261 Lines • Show Last 20 Lines