Index: cfe/trunk/lib/AST/StmtPrinter.cpp =================================================================== --- cfe/trunk/lib/AST/StmtPrinter.cpp +++ cfe/trunk/lib/AST/StmtPrinter.cpp @@ -1250,6 +1250,12 @@ OS << "'\\v'"; break; default: + // A character literal might be sign-extended, which + // would result in an invalid \U escape sequence. + // FIXME: multicharacter literals such as '\xFF\xFF\xFF\xFF' + // are not correctly handled. + if ((value & ~0xFFu) == ~0xFFu && Node->getKind() == CharacterLiteral::Ascii) + value &= 0xFFu; if (value < 256 && isPrintable((unsigned char)value)) OS << "'" << (char)value << "'"; else if (value < 256) Index: cfe/trunk/test/Misc/ast-print-char-literal.cpp =================================================================== --- cfe/trunk/test/Misc/ast-print-char-literal.cpp +++ cfe/trunk/test/Misc/ast-print-char-literal.cpp @@ -13,6 +13,8 @@ h(); } +char j = '\xFF'; + // CHECK: char c = u8'1'; // CHECK-NEXT: char d = '1'; // CHECK-NEXT: char e = U'1'; @@ -22,3 +24,4 @@ // CHECK: template // CHECK: h(); +// CHECK: char j = '\xff';