Page MenuHomePhabricator

Prevent some erroneous lit test failures due to unlucky name of working directory
ClosedPublic

Authored by mbodart on Feb 9 2016, 2:56 PM.

Details

Summary

Add CHECK-LABEL to several tests which check for the absence of "mov" in llc's assembly output.
Otherwise they will fail if the path name to the LLVM workspace contains "mov", as that name is
emitted in the .file directive.

Diff Detail

Repository
rL LLVM

Event Timeline

mbodart updated this revision to Diff 47366.Feb 9 2016, 2:56 PM
mbodart retitled this revision from to Prevent some erroneous lit test failures due to unlucky name of working directory.
mbodart updated this object.
mbodart added a reviewer: rengolin.
mbodart added a subscriber: llvm-commits.
mcrosier accepted this revision.Feb 16 2016, 11:41 AM
mcrosier added a reviewer: mcrosier.
mcrosier added a subscriber: mcrosier.

LGTM with one minor suggestion.

test/CodeGen/ARM/ldr_frame.ll
33 ↗(On Diff #47366)

Id prefer this be a little more explicit and have a CHECK-LABEL / CHECK-NOT pair per function.

This revision is now accepted and ready to land.Feb 16 2016, 11:41 AM
mbodart updated this revision to Diff 48122.Feb 16 2016, 4:12 PM
mbodart edited edge metadata.

Added individual CHECK-LABEL's per function, per review feedback.

Thanks for the cleanup, Mitch. Feel free to commit.

This revision was automatically updated to reflect the committed changes.