Page MenuHomePhabricator

Add Support to llvm-c-test dependancies
ClosedPublic

Authored by deadalnix on Feb 4 2016, 4:03 PM.

Details

Summary

As per title. It is required and don't get linked in in some builds.

Diff Detail

Repository
rL LLVM

Event Timeline

deadalnix updated this revision to Diff 46973.Feb 4 2016, 4:03 PM
deadalnix retitled this revision from to Add Support to llvm-c-test dependancies.
deadalnix updated this object.
deadalnix added reviewers: chapuni, mehdi_amini.
deadalnix added a subscriber: llvm-commits.
mehdi_amini edited edge metadata.Feb 4 2016, 4:10 PM

This should solve the build failure with BUILD_SHARED_LIBS=ON (hopefully), but it is not clear *why* it is needed in this case?

mehdi_amini accepted this revision.Feb 4 2016, 4:19 PM
mehdi_amini edited edge metadata.

Please go ahead, you pulled some ADT directly in llvm-c-test which requires a direct dependency.
This is covered with static build because cmake will pulled transitive dependency, but not on build with shared libraries for individual components.

This revision is now accepted and ready to land.Feb 4 2016, 4:19 PM
This revision was automatically updated to reflect the committed changes.