Page MenuHomePhabricator

Take 2: Use an artifical namespace so that member vars do not hide local vars.
ClosedPublic

Authored by sivachandra on Feb 4 2016, 1:30 PM.

Diff Detail

Event Timeline

sivachandra updated this revision to Diff 46957.Feb 4 2016, 1:30 PM
sivachandra retitled this revision from to Take 2: Use an artifical namespace so that member vars do not hide local vars..
sivachandra updated this object.
sivachandra added reviewers: spyffe, tfiala.
sivachandra added a subscriber: lldb-commits.
sivachandra added inline comments.Feb 4 2016, 1:32 PM
source/Expression/ExpressionSourceCode.cpp
188

This line is the only one difference between the previous version and this. An additional check for a var with name ".block_descriptor" has been added.

tfiala edited edge metadata.Feb 4 2016, 2:15 PM

I'm going to try this out now

tfiala added a subscriber: tfiala.Feb 4 2016, 4:36 PM

This tested cleanly, no failures on OS X. Lgtm.

-Todd

Thanks a lot Todd. I will put this in tomorrow morning just to be on the safer side.

tfiala accepted this revision.Feb 4 2016, 7:11 PM
tfiala edited edge metadata.

Thanks a lot Todd. I will put this in tomorrow morning just to be on the safer side.

My pleasure, Siva!

This revision is now accepted and ready to land.Feb 4 2016, 7:11 PM
sivachandra closed this revision.Feb 5 2016, 11:14 AM