This is an archive of the discontinued LLVM Phabricator instance.

Fix a thinko in StackFrame::GetInScopeVariableList.
ClosedPublic

Authored by sivachandra on Jan 29 2016, 6:11 PM.

Reviewers

Commits

sivachandra retitled this revision from to Fix a thinko in StackFrame::GetInScopeVariableList..

sivachandra updated this object.

sivachandra added a reviewer: clayborg.

I found this while digging into some other problem. Test run is clean for me.

Looks good.

This revision is now accepted and ready to land.Feb 1 2016, 10:06 AM

Path

Size

source/

Target/

2 lines

Show First 20 Lines • Show All 591 Lines • ▼ Show 20 Lines	if (m_sc.block)
const bool get_parent_variables = true;		const bool get_parent_variables = true;
const bool stop_if_block_is_inlined_function = true;		const bool stop_if_block_is_inlined_function = true;
m_sc.block->AppendVariables (can_create,		m_sc.block->AppendVariables (can_create,
get_parent_variables,		get_parent_variables,
stop_if_block_is_inlined_function,		stop_if_block_is_inlined_function,
var_list_sp.get());		var_list_sp.get());
}		}

if (m_sc.comp_unit)		if (m_sc.comp_unit && get_file_globals)
{		{
VariableListSP global_variable_list_sp (m_sc.comp_unit->GetVariableList(true));		VariableListSP global_variable_list_sp (m_sc.comp_unit->GetVariableList(true));
if (global_variable_list_sp)		if (global_variable_list_sp)
var_list_sp->AddVariables (global_variable_list_sp.get());		var_list_sp->AddVariables (global_variable_list_sp.get());
}		}

return var_list_sp;		return var_list_sp;
}		}
▲ Show 20 Lines • Show All 986 Lines • Show Last 20 Lines