Page MenuHomePhabricator

[patch] Merge identical strings (Rafael's patch)
Needs ReviewPublic

Authored by ruiu on Jan 28 2016, 12:40 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Event Timeline

ruiu updated this revision to Diff 46306.Jan 28 2016, 12:40 PM
ruiu retitled this revision from to [patch] Merge identical strings (Rafael's patch).
ruiu updated this object.
ruiu added inline comments.Jan 28 2016, 12:49 PM
ELF/InputFiles.h
132

unsigned -> size_t.

It is better to write a comment about the number. (The offset in .dynsym for a symbol.)

ELF/OutputSections.cpp
615

You want to update this comment (it no longer reserve strings.)

1348

Can you describe the background why we have HashIt? Particularly, about the fact that we do uniquify strings only for local symbols and why.

I will implement the other suggestions in a second.

ELF/InputFiles.h
132

This is st_name, which is Elf_Word, so always 32 bits.