Page MenuHomePhabricator

Fix crashing on user-defined conversion.
ClosedPublic

Authored by congliu on Jan 25 2016, 8:36 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

congliu updated this revision to Diff 45871.Jan 25 2016, 8:36 AM
congliu retitled this revision from to Fix crashing on user-defined conversion..
congliu updated this object.
congliu added a reviewer: alexfh.
congliu added a subscriber: cfe-commits.
aaron.ballman added inline comments.
clang-tidy/misc/VirtualNearMissCheck.cpp
175 ↗(On Diff #45871)

Why not isa<CXXConversionDecl>(MD) instead?

congliu updated this revision to Diff 45873.Jan 25 2016, 9:20 AM
  • Address the comment and clean up the code.
clang-tidy/misc/VirtualNearMissCheck.cpp
175 ↗(On Diff #45871)

Thanks!

aaron.ballman accepted this revision.Jan 25 2016, 9:28 AM
aaron.ballman added a reviewer: aaron.ballman.

LGTM, thank you!

This revision is now accepted and ready to land.Jan 25 2016, 9:28 AM
This revision was automatically updated to reflect the committed changes.
alexfh edited edge metadata.Jan 26 2016, 3:01 AM

Thank you for the fix! Committed as r258801.