Index: llvm/trunk/lib/Analysis/InlineCost.cpp =================================================================== --- llvm/trunk/lib/Analysis/InlineCost.cpp +++ llvm/trunk/lib/Analysis/InlineCost.cpp @@ -573,16 +573,16 @@ } void CallAnalyzer::updateThreshold(CallSite CS, Function &Callee) { - // If -inline-threshold is not given, listen to the optsize attribute when it - // would decrease the threshold. + // If -inline-threshold is not given, listen to the optsize and minsize + // attributes when they would decrease the threshold. Function *Caller = CS.getCaller(); - // FIXME: Use Function::optForSize() - bool OptSize = Caller->hasFnAttribute(Attribute::OptimizeForSize); - - if (!(DefaultInlineThreshold.getNumOccurrences() > 0) && OptSize && - OptSizeThreshold < Threshold) - Threshold = OptSizeThreshold; + if (!(DefaultInlineThreshold.getNumOccurrences() > 0)) { + if (Caller->optForMinSize() && OptMinSizeThreshold < Threshold) + Threshold = OptMinSizeThreshold; + else if (Caller->optForSize() && OptSizeThreshold < Threshold) + Threshold = OptSizeThreshold; + } // If profile information is available, use that to adjust threshold of hot // and cold functions. Index: llvm/trunk/test/Transforms/Inline/inline-optsize.ll =================================================================== --- llvm/trunk/test/Transforms/Inline/inline-optsize.ll +++ llvm/trunk/test/Transforms/Inline/inline-optsize.ll @@ -1,5 +1,6 @@ ; RUN: opt -S -Oz < %s | FileCheck %s -check-prefix=OZ ; RUN: opt -S -O2 < %s | FileCheck %s -check-prefix=O2 +; RUN: opt -S -Os < %s | FileCheck %s -check-prefix=OS ; The inline threshold for a function with the optsize attribute is currently ; the same as the global inline threshold for -Os. Check that the optsize @@ -24,10 +25,20 @@ ret i32 %x5 } -; @inner() should be inlined for -O2 but not for -Oz. +; @inner() should be inlined for -O2 and -Os but not for -Oz. ; OZ: call ; O2-NOT: call +; OS-NOT: call define i32 @outer() optsize { %r = call i32 @inner() ret i32 %r } + +; @inner() should not be inlined for -O2, -Os and -Oz. +; OZ: call +; O2: call +; OS: call +define i32 @outer2() minsize { + %r = call i32 @inner() + ret i32 %r +}