Index: include/__hash_table =================================================================== --- include/__hash_table +++ include/__hash_table @@ -100,6 +100,21 @@ return size_t(1) << (std::numeric_limits::digits - __clz(__n-1)); } +struct __extract_key_fail_tag {}; +struct __extract_key_self_tag {}; +struct __extract_key_first_tag {}; + +template ::type> +struct __can_extract_key + : conditional::value, __extract_key_self_tag, + __extract_key_fail_tag>::type {}; + +template +struct __can_extract_key<_Pair, _Key, pair<_First, _Second>> + : conditional::type, _Key>::value, + __extract_key_first_tag, __extract_key_fail_tag>::type {}; + template class __hash_table; template class _LIBCPP_TYPE_VIS_ONLY __hash_iterator; @@ -903,6 +918,7 @@ typedef typename _NodeTypes::__node_value_type __node_value_type; typedef typename _NodeTypes::__container_value_type __container_value_type; + typedef typename _NodeTypes::key_type key_type; typedef value_type& reference; typedef const value_type& const_reference; typedef typename __alloc_traits::pointer pointer; @@ -1041,13 +1057,49 @@ #ifndef _LIBCPP_CXX03_LANG template + _LIBCPP_INLINE_VISIBILITY pair __emplace_unique_key_args(_Key const& __k, _Args&&... __args); template - pair __emplace_unique(_Args&&... __args); + _LIBCPP_INLINE_VISIBILITY + pair __emplace_unique_impl(_Args&&... __args); + + template + _LIBCPP_INLINE_VISIBILITY + pair __emplace_unique(_Pp&& __x) { + return __emplace_unique_extract_key(_VSTD::forward<_Pp>(__x), + __can_extract_key<_Pp, key_type>()); + } + template + _LIBCPP_INLINE_VISIBILITY + pair __emplace_unique(_Args&&... __args) { + return __emplace_unique_impl(_VSTD::forward<_Args>(__args)...); + } + + template + _LIBCPP_INLINE_VISIBILITY + pair + __emplace_unique_extract_key(_Pp&& __x, __extract_key_fail_tag) { + return __emplace_unique_impl(_VSTD::forward<_Pp>(__x)); + } + template + _LIBCPP_INLINE_VISIBILITY + pair + __emplace_unique_extract_key(_Pp&& __x, __extract_key_self_tag) { + return __emplace_unique_key_args(__x, _VSTD::forward<_Pp>(__x)); + } + template + _LIBCPP_INLINE_VISIBILITY + pair + __emplace_unique_extract_key(_Pp&& __x, __extract_key_first_tag) { + return __emplace_unique_key_args(__x.first, _VSTD::forward<_Pp>(__x)); + } + template + _LIBCPP_INLINE_VISIBILITY iterator __emplace_multi(_Args&&... __args); template + _LIBCPP_INLINE_VISIBILITY iterator __emplace_hint_multi(const_iterator __p, _Args&&... __args); @@ -1989,7 +2041,7 @@ template template pair::iterator, bool> -__hash_table<_Tp, _Hash, _Equal, _Alloc>::__emplace_unique(_Args&&... __args) +__hash_table<_Tp, _Hash, _Equal, _Alloc>::__emplace_unique_impl(_Args&&... __args) { __node_holder __h = __construct_node(_VSTD::forward<_Args>(__args)...); pair __r = __node_insert_unique(__h.get()); Index: test/libcxx/containers/unord/unord.map/insert_dup_alloc.pass.cpp =================================================================== --- /dev/null +++ test/libcxx/containers/unord/unord.map/insert_dup_alloc.pass.cpp @@ -0,0 +1,103 @@ +//===----------------------------------------------------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is dual licensed under the MIT and the University of Illinois Open +// Source Licenses. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +// Check that we don't allocate when trying to insert a duplicate value into a +// unordered_map. + +#include +#include +#include + +#include "container_test_types.h" +#include "count_new.hpp" +#include "test_macros.h" + +#if TEST_STD_VER >= 11 +template +void PrintInfo(int line, Arg&& arg) +#else +template +void PrintInfo(int line, Arg arg) +#endif +{ + std::cout << "In " << __FILE__ << ":" << line << ":\n " << arg << "\n" << std::endl; +} +#define PRINT(...) PrintInfo(__LINE__, __VA_ARGS__) + +template +void testContainerInsert() +{ + typedef typename Container::value_type ValueTp; + typedef std::pair + PairTp; + typedef Container C; + typedef std::pair R; + ConstructController* cc = getConstructController(); + cc->reset(); + Container c; + cc->expect(); + + PRINT("Expect a malloc in initial insertion"); + assert(c.insert(ValueTp(3, 4)).second); + assert(!cc->unchecked()); + DisableAllocationGuard g; + + PRINT("Checking for mallocs in insert(value_type&&)"); + assert(!c.insert(ValueTp(3, 4)).second); + assert(!c.insert(PairTp(3, 4)).second); + + PRINT("Checking for mallocs in insert(value_type&)"); + { + ValueTp v(3, 4); + assert(!c.insert(v).second); + } + { + PairTp v(3, 4); + assert(!c.insert(v).second); + } + + PRINT("Checking for mallocs in insert(const value_type&)"); + { + const ValueTp v(3, 4); + assert(!c.insert(v).second); + } + { + const PairTp v(3, 4); + assert(!c.insert(v).second); + } + + PRINT("Checking for mallocs in emplace(value_type&&)"); + assert(!c.emplace(ValueTp(3, 4)).second); + assert(!c.emplace(PairTp(3, 4)).second); + + PRINT("Checking for mallocs in emplace(value_type&)"); + { + ValueTp v(3, 4); + assert(!c.emplace(v).second); + } + { + PairTp v(3, 4); + assert(!c.emplace(v).second); + } + + PRINT("Checking for mallocs in emplace(const value_type&)"); + { + const ValueTp v(3, 4); + assert(!c.emplace(v).second); + } + { + const PairTp v(3, 4); + assert(!c.emplace(v).second); + } +} + +int main() +{ + testContainerInsert >(); +} Index: test/libcxx/containers/unord/unord.set/insert_dup_alloc.pass.cpp =================================================================== --- test/libcxx/containers/unord/unord.set/insert_dup_alloc.pass.cpp +++ test/libcxx/containers/unord/unord.set/insert_dup_alloc.pass.cpp @@ -60,6 +60,21 @@ const ValueTp v(3); assert(!c.insert(v).second); } + + PRINT("Checking for mallocs in emplace(value_type&&)"); + assert(!c.emplace(ValueTp(3)).second); + + PRINT("Checking for mallocs in emplace(value_type&)"); + { + ValueTp v(3); + assert(!c.emplace(v).second); + } + + PRINT("Checking for mallocs in emplace(const value_type&)"); + { + const ValueTp v(3); + assert(!c.emplace(v).second); + } } int main()