Page MenuHomePhabricator

[Gold] Pass -mllvm options to the gold plugin
AbandonedPublic

Authored by jmolloy on Jan 11 2016, 3:47 AM.

Details

Reviewers
rafael
Summary

The gold plugin can take LLVM options, but the syntax is confusing: -Wl,-plugin-opt= or -Xlinker -plugin-opt=.

Instead, pass -mllvm options through to Gold so the obvious syntax works.

Diff Detail

Repository
rL LLVM

Event Timeline

jmolloy updated this revision to Diff 44461.Jan 11 2016, 3:47 AM
jmolloy retitled this revision from to [Gold] Pass -mllvm options to the gold plugin.
jmolloy updated this object.
jmolloy added a reviewer: rafael.
jmolloy set the repository for this revision to rL LLVM.
jmolloy added a subscriber: cfe-commits.
rafael edited edge metadata.Jan 11 2016, 4:11 PM
rafael added a subscriber: rafael.

Maybe. I would like a second opinion on this one. The potential issue
I see is that we are using compiler options during linking. Normally
they are just ignored. Is it surprising if LTO starts using them?

Cheers,
Rafael

jmolloy abandoned this revision.Jan 12 2016, 4:30 AM

Abandoning - this isn't as clear-cut as I thought.