diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -218,6 +218,8 @@ (`#65156 `_) - Clang no longer considers the loss of ``__unaligned`` qualifier from objects as an invalid conversion during method function overload resolution. +- Fix parser crash when dealing with ill-formed objective C++ header code. Fixes + (`#64836 `_) Bug Fixes to Compiler Builtins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/clang/lib/Parse/ParseDecl.cpp b/clang/lib/Parse/ParseDecl.cpp --- a/clang/lib/Parse/ParseDecl.cpp +++ b/clang/lib/Parse/ParseDecl.cpp @@ -6667,7 +6667,7 @@ // Objective-C++: Detect C++ keywords and try to prevent further errors by // treating these keyword as valid member names. if (getLangOpts().ObjC && getLangOpts().CPlusPlus && - Tok.getIdentifierInfo() && + !Tok.isAnnotation() && Tok.getIdentifierInfo() && Tok.getIdentifierInfo()->isCPlusPlusKeyword(getLangOpts())) { Diag(getMissingDeclaratorIdLoc(D, Tok.getLocation()), diag::err_expected_member_name_or_semi_objcxx_keyword) diff --git a/clang/test/Parser/gh64836.cpp b/clang/test/Parser/gh64836.cpp new file mode 100644 --- /dev/null +++ b/clang/test/Parser/gh64836.cpp @@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -xobjective-c++-header %s + +template +class C {}; + +class B { + p // expected-error {{unknown type name 'p'}} + private: // expected-error {{'private' is a keyword in Objective-C++}} + void f() {} // expected-error {{expected '(' for function-style cast or type construction}} + C c; // expected-error {{use of undeclared identifier 'f'}} + // expected-error@-1 {{expected member name}} +};