diff --git a/mlir/docs/ReleaseNotes.md b/mlir/docs/ReleaseNotes.md --- a/mlir/docs/ReleaseNotes.md +++ b/mlir/docs/ReleaseNotes.md @@ -8,6 +8,14 @@ [TOC] +## LLVM 18 + +### Properties: beyond attributes + +See LLVM 17 notes below. The Dialect option `let usePropertiesForAttributes = 1;` is +now the default. You can set it to 0 to revert to the previous behavior. This will be +removed in LLVM 19. + ## LLVM 17 See also the [deprecations and refactoring](https://mlir.llvm.org/deprecation/) doc. diff --git a/mlir/examples/toy/Ch2/include/toy/Dialect.h b/mlir/examples/toy/Ch2/include/toy/Dialect.h --- a/mlir/examples/toy/Ch2/include/toy/Dialect.h +++ b/mlir/examples/toy/Ch2/include/toy/Dialect.h @@ -14,6 +14,7 @@ #ifndef MLIR_TUTORIAL_TOY_DIALECT_H_ #define MLIR_TUTORIAL_TOY_DIALECT_H_ +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/FunctionInterfaces.h" #include "mlir/IR/SymbolTable.h" diff --git a/mlir/examples/toy/Ch3/include/toy/Dialect.h b/mlir/examples/toy/Ch3/include/toy/Dialect.h --- a/mlir/examples/toy/Ch3/include/toy/Dialect.h +++ b/mlir/examples/toy/Ch3/include/toy/Dialect.h @@ -14,6 +14,7 @@ #ifndef MLIR_TUTORIAL_TOY_DIALECT_H_ #define MLIR_TUTORIAL_TOY_DIALECT_H_ +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/FunctionInterfaces.h" #include "mlir/IR/SymbolTable.h" diff --git a/mlir/examples/toy/Ch4/include/toy/Dialect.h b/mlir/examples/toy/Ch4/include/toy/Dialect.h --- a/mlir/examples/toy/Ch4/include/toy/Dialect.h +++ b/mlir/examples/toy/Ch4/include/toy/Dialect.h @@ -14,6 +14,7 @@ #ifndef MLIR_TUTORIAL_TOY_DIALECT_H_ #define MLIR_TUTORIAL_TOY_DIALECT_H_ +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/FunctionInterfaces.h" diff --git a/mlir/examples/toy/Ch5/include/toy/Dialect.h b/mlir/examples/toy/Ch5/include/toy/Dialect.h --- a/mlir/examples/toy/Ch5/include/toy/Dialect.h +++ b/mlir/examples/toy/Ch5/include/toy/Dialect.h @@ -14,6 +14,7 @@ #ifndef MLIR_TUTORIAL_TOY_DIALECT_H_ #define MLIR_TUTORIAL_TOY_DIALECT_H_ +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/FunctionInterfaces.h" diff --git a/mlir/examples/toy/Ch6/include/toy/Dialect.h b/mlir/examples/toy/Ch6/include/toy/Dialect.h --- a/mlir/examples/toy/Ch6/include/toy/Dialect.h +++ b/mlir/examples/toy/Ch6/include/toy/Dialect.h @@ -14,6 +14,7 @@ #ifndef MLIR_TUTORIAL_TOY_DIALECT_H_ #define MLIR_TUTORIAL_TOY_DIALECT_H_ +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/FunctionInterfaces.h" diff --git a/mlir/examples/toy/Ch7/include/toy/Dialect.h b/mlir/examples/toy/Ch7/include/toy/Dialect.h --- a/mlir/examples/toy/Ch7/include/toy/Dialect.h +++ b/mlir/examples/toy/Ch7/include/toy/Dialect.h @@ -14,6 +14,7 @@ #ifndef MLIR_TUTORIAL_TOY_DIALECT_H_ #define MLIR_TUTORIAL_TOY_DIALECT_H_ +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/FunctionInterfaces.h" diff --git a/mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPU.td b/mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPU.td --- a/mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPU.td +++ b/mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPU.td @@ -29,7 +29,6 @@ "gpu::GPUDialect" ]; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } //===----------------------------------------------------------------------===// diff --git a/mlir/include/mlir/Dialect/AMX/AMX.td b/mlir/include/mlir/Dialect/AMX/AMX.td --- a/mlir/include/mlir/Dialect/AMX/AMX.td +++ b/mlir/include/mlir/Dialect/AMX/AMX.td @@ -55,8 +55,6 @@ For details, see the Intel documentation: https://software.intel.com/content/www/us/en/develop/articles/intel-sdm.html }]; - - let usePropertiesForAttributes = 1; } //===----------------------------------------------------------------------===// diff --git a/mlir/include/mlir/Dialect/Affine/IR/AffineOps.td b/mlir/include/mlir/Dialect/Affine/IR/AffineOps.td --- a/mlir/include/mlir/Dialect/Affine/IR/AffineOps.td +++ b/mlir/include/mlir/Dialect/Affine/IR/AffineOps.td @@ -23,7 +23,6 @@ let name = "affine"; let cppNamespace = "::mlir::affine"; let hasConstantMaterializer = 1; - let usePropertiesForAttributes = 1; let dependentDialects = ["arith::ArithDialect"]; } diff --git a/mlir/include/mlir/Dialect/Arith/IR/ArithBase.td b/mlir/include/mlir/Dialect/Arith/IR/ArithBase.td --- a/mlir/include/mlir/Dialect/Arith/IR/ArithBase.td +++ b/mlir/include/mlir/Dialect/Arith/IR/ArithBase.td @@ -24,7 +24,6 @@ let hasConstantMaterializer = 1; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } // The predicate indicates the type of the comparison to perform: diff --git a/mlir/include/mlir/Dialect/ArmNeon/ArmNeon.td b/mlir/include/mlir/Dialect/ArmNeon/ArmNeon.td --- a/mlir/include/mlir/Dialect/ArmNeon/ArmNeon.td +++ b/mlir/include/mlir/Dialect/ArmNeon/ArmNeon.td @@ -24,8 +24,6 @@ def ArmNeon_Dialect : Dialect { let name = "arm_neon"; let cppNamespace = "::mlir::arm_neon"; - let usePropertiesForAttributes = 1; - // Note: this does not need to depend on LLVMDialect as long as functions in // this dialect (such as canonicalization) do not produce entities belonging diff --git a/mlir/include/mlir/Dialect/ArmSVE/ArmSVE.td b/mlir/include/mlir/Dialect/ArmSVE/ArmSVE.td --- a/mlir/include/mlir/Dialect/ArmSVE/ArmSVE.td +++ b/mlir/include/mlir/Dialect/ArmSVE/ArmSVE.td @@ -28,7 +28,6 @@ This dialect contains the definitions necessary to target specific Arm SVE scalable vector operations. }]; - let usePropertiesForAttributes = 1; } diff --git a/mlir/include/mlir/Dialect/Async/IR/AsyncDialect.td b/mlir/include/mlir/Dialect/Async/IR/AsyncDialect.td --- a/mlir/include/mlir/Dialect/Async/IR/AsyncDialect.td +++ b/mlir/include/mlir/Dialect/Async/IR/AsyncDialect.td @@ -29,7 +29,6 @@ }]; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ /// The name of a unit attribute on funcs that are allowed to have a diff --git a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td --- a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td +++ b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td @@ -72,7 +72,6 @@ kEscapeAttrName = "bufferization.escape"; }]; let hasOperationAttrVerify = 1; - let usePropertiesForAttributes = 1; } #endif // BUFFERIZATION_BASE diff --git a/mlir/include/mlir/Dialect/Complex/IR/ComplexBase.td b/mlir/include/mlir/Dialect/Complex/IR/ComplexBase.td --- a/mlir/include/mlir/Dialect/Complex/IR/ComplexBase.td +++ b/mlir/include/mlir/Dialect/Complex/IR/ComplexBase.td @@ -22,7 +22,6 @@ let dependentDialects = ["arith::ArithDialect"]; let hasConstantMaterializer = 1; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } #endif // COMPLEX_BASE diff --git a/mlir/include/mlir/Dialect/ControlFlow/IR/ControlFlowOps.td b/mlir/include/mlir/Dialect/ControlFlow/IR/ControlFlowOps.td --- a/mlir/include/mlir/Dialect/ControlFlow/IR/ControlFlowOps.td +++ b/mlir/include/mlir/Dialect/ControlFlow/IR/ControlFlowOps.td @@ -28,8 +28,6 @@ constructs. These constructs generally represent control flow directly on SSA blocks of a control flow graph. }]; - let usePropertiesForAttributes = 1; - } class CF_Op traits = []> : diff --git a/mlir/include/mlir/Dialect/DLTI/DLTIBase.td b/mlir/include/mlir/Dialect/DLTI/DLTIBase.td --- a/mlir/include/mlir/Dialect/DLTI/DLTIBase.td +++ b/mlir/include/mlir/Dialect/DLTI/DLTIBase.td @@ -45,7 +45,6 @@ }]; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } def DLTI_DataLayoutEntryAttr : DialectAttr< diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitCBase.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitCBase.td --- a/mlir/include/mlir/Dialect/EmitC/IR/EmitCBase.td +++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitCBase.td @@ -31,7 +31,6 @@ let hasConstantMaterializer = 1; let useDefaultTypePrinterParser = 1; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } #endif // MLIR_DIALECT_EMITC_IR_EMITCBASE diff --git a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td --- a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td +++ b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td @@ -22,7 +22,6 @@ let name = "func"; let cppNamespace = "::mlir::func"; let hasConstantMaterializer = 1; - let usePropertiesForAttributes = 1; } // Base class for Func dialect ops. diff --git a/mlir/include/mlir/Dialect/GPU/IR/GPUBase.td b/mlir/include/mlir/Dialect/GPU/IR/GPUBase.td --- a/mlir/include/mlir/Dialect/GPU/IR/GPUBase.td +++ b/mlir/include/mlir/Dialect/GPU/IR/GPUBase.td @@ -57,7 +57,6 @@ let dependentDialects = ["arith::ArithDialect"]; let useDefaultAttributePrinterParser = 1; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; } //===----------------------------------------------------------------------===// diff --git a/mlir/include/mlir/Dialect/IRDL/IR/IRDL.td b/mlir/include/mlir/Dialect/IRDL/IR/IRDL.td --- a/mlir/include/mlir/Dialect/IRDL/IR/IRDL.td +++ b/mlir/include/mlir/Dialect/IRDL/IR/IRDL.td @@ -71,7 +71,6 @@ let useDefaultAttributePrinterParser = 1; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; let name = "irdl"; let cppNamespace = "::mlir::irdl"; diff --git a/mlir/include/mlir/Dialect/Index/IR/IndexDialect.td b/mlir/include/mlir/Dialect/Index/IR/IndexDialect.td --- a/mlir/include/mlir/Dialect/Index/IR/IndexDialect.td +++ b/mlir/include/mlir/Dialect/Index/IR/IndexDialect.td @@ -83,7 +83,6 @@ let hasConstantMaterializer = 1; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } #endif // INDEX_DIALECT diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.td --- a/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.td +++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.td @@ -20,7 +20,6 @@ let hasRegionArgAttrVerify = 1; let hasRegionResultAttrVerify = 1; let hasOperationAttrVerify = 1; - let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ /// Name of the data layout attributes. diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgBase.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgBase.td --- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgBase.td +++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgBase.td @@ -46,7 +46,6 @@ let hasCanonicalizer = 1; let hasOperationAttrVerify = 1; let hasConstantMaterializer = 1; - let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ /// Attribute name used to to memoize indexing maps for named ops. constexpr const static ::llvm::StringLiteral diff --git a/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramBase.td b/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramBase.td --- a/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramBase.td +++ b/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramBase.td @@ -29,7 +29,6 @@ let useDefaultAttributePrinterParser = 1; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; } #endif // MLPROGRAM_BASE diff --git a/mlir/include/mlir/Dialect/Math/IR/MathBase.td b/mlir/include/mlir/Dialect/Math/IR/MathBase.td --- a/mlir/include/mlir/Dialect/Math/IR/MathBase.td +++ b/mlir/include/mlir/Dialect/Math/IR/MathBase.td @@ -30,7 +30,6 @@ ``` }]; let hasConstantMaterializer = 1; - let usePropertiesForAttributes = 1; let dependentDialects = [ "::mlir::arith::ArithDialect" ]; diff --git a/mlir/include/mlir/Dialect/MemRef/IR/MemRefBase.td b/mlir/include/mlir/Dialect/MemRef/IR/MemRefBase.td --- a/mlir/include/mlir/Dialect/MemRef/IR/MemRefBase.td +++ b/mlir/include/mlir/Dialect/MemRef/IR/MemRefBase.td @@ -21,7 +21,6 @@ }]; let dependentDialects = ["arith::ArithDialect"]; let hasConstantMaterializer = 1; - let usePropertiesForAttributes = 1; } #endif // MEMREF_BASE diff --git a/mlir/include/mlir/Dialect/NVGPU/IR/NVGPU.td b/mlir/include/mlir/Dialect/NVGPU/IR/NVGPU.td --- a/mlir/include/mlir/Dialect/NVGPU/IR/NVGPU.td +++ b/mlir/include/mlir/Dialect/NVGPU/IR/NVGPU.td @@ -37,7 +37,6 @@ }]; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; let useDefaultAttributePrinterParser = 1; let extraClassDeclaration = [{ diff --git a/mlir/include/mlir/Dialect/OpenACC/OpenACCBase.td b/mlir/include/mlir/Dialect/OpenACC/OpenACCBase.td --- a/mlir/include/mlir/Dialect/OpenACC/OpenACCBase.td +++ b/mlir/include/mlir/Dialect/OpenACC/OpenACCBase.td @@ -26,7 +26,6 @@ let useDefaultAttributePrinterParser = 1; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; let cppNamespace = "::mlir::acc"; let dependentDialects = ["::mlir::memref::MemRefDialect","::mlir::LLVM::LLVMDialect"]; } diff --git a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td --- a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td +++ b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td @@ -28,7 +28,6 @@ let cppNamespace = "::mlir::omp"; let dependentDialects = ["::mlir::LLVM::LLVMDialect, ::mlir::func::FuncDialect"]; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } // OmpCommon requires definition of OpenACC_Dialect. diff --git a/mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td b/mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td --- a/mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td +++ b/mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td @@ -66,7 +66,6 @@ let cppNamespace = "::mlir::pdl"; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ void registerTypes(); }]; diff --git a/mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td b/mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td --- a/mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td +++ b/mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td @@ -38,7 +38,6 @@ let name = "pdl_interp"; let cppNamespace = "::mlir::pdl_interp"; let dependentDialects = ["pdl::PDLDialect"]; - let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ /// Returns the name of the function containing the matcher code. This /// function is called by the interpreter when matching an operation. diff --git a/mlir/include/mlir/Dialect/Quant/QuantOpsBase.td b/mlir/include/mlir/Dialect/Quant/QuantOpsBase.td --- a/mlir/include/mlir/Dialect/Quant/QuantOpsBase.td +++ b/mlir/include/mlir/Dialect/Quant/QuantOpsBase.td @@ -20,7 +20,6 @@ let cppNamespace = "::mlir::quant"; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; } //===----------------------------------------------------------------------===// diff --git a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td --- a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td +++ b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td @@ -26,7 +26,6 @@ let name = "scf"; let cppNamespace = "::mlir::scf"; let dependentDialects = ["arith::ArithDialect"]; - let usePropertiesForAttributes = 1; } // Base class for SCF dialect ops. diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td --- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td +++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td @@ -52,7 +52,6 @@ let hasOperationAttrVerify = 1; let hasRegionArgAttrVerify = 1; let hasRegionResultAttrVerify = 1; - let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ void registerAttributes(); diff --git a/mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td b/mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td --- a/mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td +++ b/mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td @@ -41,7 +41,6 @@ let useDefaultTypePrinterParser = 1; let hasConstantMaterializer = 1; let hasOperationAttrVerify = 1; - let usePropertiesForAttributes = 1; } class Shape_Type : TypeDef { diff --git a/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorBase.td b/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorBase.td --- a/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorBase.td +++ b/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorBase.td @@ -85,7 +85,6 @@ let useDefaultAttributePrinterParser = 1; let useDefaultTypePrinterParser = 1; - let usePropertiesForAttributes = 1; } #endif // SPARSETENSOR_BASE diff --git a/mlir/include/mlir/Dialect/Tensor/IR/TensorBase.td b/mlir/include/mlir/Dialect/Tensor/IR/TensorBase.td --- a/mlir/include/mlir/Dialect/Tensor/IR/TensorBase.td +++ b/mlir/include/mlir/Dialect/Tensor/IR/TensorBase.td @@ -47,7 +47,6 @@ let hasCanonicalizer = 1; let hasConstantMaterializer = 1; - let usePropertiesForAttributes = 1; let dependentDialects = [ "affine::AffineDialect", "arith::ArithDialect", diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td --- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td +++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td @@ -45,7 +45,6 @@ let cppNamespace = "mlir::tosa"; let hasConstantMaterializer = 1; let useDefaultAttributePrinterParser = 1; - let usePropertiesForAttributes = 1; } //===----------------------------------------------------------------------===// diff --git a/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td b/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td --- a/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td +++ b/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td @@ -19,8 +19,6 @@ let cppNamespace = "::mlir::transform"; let hasOperationAttrVerify = 1; - let usePropertiesForAttributes = 1; - let extraClassDeclaration = [{ /// Name of the attribute attachable to the symbol table operation /// containing named sequences. This is used to trigger verification. diff --git a/mlir/include/mlir/Dialect/UB/IR/UBOps.h b/mlir/include/mlir/Dialect/UB/IR/UBOps.h --- a/mlir/include/mlir/Dialect/UB/IR/UBOps.h +++ b/mlir/include/mlir/Dialect/UB/IR/UBOps.h @@ -9,6 +9,7 @@ #ifndef MLIR_DIALECT_UB_IR_OPS_H #define MLIR_DIALECT_UB_IR_OPS_H +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/OpImplementation.h" #include "mlir/Interfaces/SideEffectInterfaces.h" diff --git a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td --- a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td +++ b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td @@ -29,7 +29,6 @@ let useDefaultAttributePrinterParser = 1; let hasConstantMaterializer = 1; - let usePropertiesForAttributes = 1; let dependentDialects = ["arith::ArithDialect"]; } diff --git a/mlir/include/mlir/Dialect/X86Vector/X86Vector.td b/mlir/include/mlir/Dialect/X86Vector/X86Vector.td --- a/mlir/include/mlir/Dialect/X86Vector/X86Vector.td +++ b/mlir/include/mlir/Dialect/X86Vector/X86Vector.td @@ -24,7 +24,6 @@ def X86Vector_Dialect : Dialect { let name = "x86vector"; let cppNamespace = "::mlir::x86vector"; - let usePropertiesForAttributes = 1; } //===----------------------------------------------------------------------===// diff --git a/mlir/include/mlir/IR/BuiltinDialect.td b/mlir/include/mlir/IR/BuiltinDialect.td --- a/mlir/include/mlir/IR/BuiltinDialect.td +++ b/mlir/include/mlir/IR/BuiltinDialect.td @@ -23,7 +23,6 @@ let cppNamespace = "::mlir"; let useDefaultAttributePrinterParser = 0; let useDefaultTypePrinterParser = 0; - let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ private: // Register the builtin Attributes. diff --git a/mlir/include/mlir/IR/DialectBase.td b/mlir/include/mlir/IR/DialectBase.td --- a/mlir/include/mlir/IR/DialectBase.td +++ b/mlir/include/mlir/IR/DialectBase.td @@ -89,7 +89,7 @@ bit isExtensible = 0; // Whether inherent Attributes defined in ODS will be stored as Properties. - bit usePropertiesForAttributes = 0; + bit usePropertiesForAttributes = 1; } #endif // DIALECTBASE_TD diff --git a/mlir/test/lib/Dialect/Test/TestDialect.td b/mlir/test/lib/Dialect/Test/TestDialect.td --- a/mlir/test/lib/Dialect/Test/TestDialect.td +++ b/mlir/test/lib/Dialect/Test/TestDialect.td @@ -24,7 +24,6 @@ let useDefaultTypePrinterParser = 0; let useDefaultAttributePrinterParser = 1; let isExtensible = 1; - let usePropertiesForAttributes = 1; let dependentDialects = ["::mlir::DLTIDialect"]; let extraClassDeclaration = [{ diff --git a/mlir/test/mlir-tblgen/constraint-unique.td b/mlir/test/mlir-tblgen/constraint-unique.td --- a/mlir/test/mlir-tblgen/constraint-unique.td +++ b/mlir/test/mlir-tblgen/constraint-unique.td @@ -4,6 +4,7 @@ def Test_Dialect : Dialect { let name = "test"; + let usePropertiesForAttributes = 0; } class NS_Op traits = []> : diff --git a/mlir/test/mlir-tblgen/op-attribute.td b/mlir/test/mlir-tblgen/op-attribute.td --- a/mlir/test/mlir-tblgen/op-attribute.td +++ b/mlir/test/mlir-tblgen/op-attribute.td @@ -9,6 +9,7 @@ def Test_Dialect : Dialect { let name = "test"; let cppNamespace = "foobar"; + let usePropertiesForAttributes = 0; } class NS_Op traits> : Op; @@ -176,6 +177,7 @@ def Test2_Dialect : Dialect { let name = "test2"; let cppNamespace = "foobar2"; + let usePropertiesForAttributes = 0; } def AgetOp : Op { let arguments = (ins diff --git a/mlir/test/mlir-tblgen/op-decl-and-defs.td b/mlir/test/mlir-tblgen/op-decl-and-defs.td --- a/mlir/test/mlir-tblgen/op-decl-and-defs.td +++ b/mlir/test/mlir-tblgen/op-decl-and-defs.td @@ -12,6 +12,7 @@ def Test_Dialect : Dialect { let name = "test"; let cppNamespace = "NS"; + let usePropertiesForAttributes = 0; } class NS_Op traits> : Op; diff --git a/mlir/test/mlir-tblgen/op-format.td b/mlir/test/mlir-tblgen/op-format.td --- a/mlir/test/mlir-tblgen/op-format.td +++ b/mlir/test/mlir-tblgen/op-format.td @@ -4,6 +4,7 @@ def TestDialect : Dialect { let name = "test"; + let usePropertiesForAttributes = 0; } class TestFormat_Op traits = []> : Op { diff --git a/mlir/test/mlir-tblgen/op-result.td b/mlir/test/mlir-tblgen/op-result.td --- a/mlir/test/mlir-tblgen/op-result.td +++ b/mlir/test/mlir-tblgen/op-result.td @@ -5,6 +5,7 @@ def Test_Dialect : Dialect { let name = "test"; + let usePropertiesForAttributes = 0; } class NS_Op traits> : Op; diff --git a/mlir/test/python/lib/PythonTestDialect.h b/mlir/test/python/lib/PythonTestDialect.h --- a/mlir/test/python/lib/PythonTestDialect.h +++ b/mlir/test/python/lib/PythonTestDialect.h @@ -9,6 +9,7 @@ #ifndef MLIR_TEST_PYTHON_LIB_PYTHONTESTDIALECT_H #define MLIR_TEST_PYTHON_LIB_PYTHONTESTDIALECT_H +#include "mlir/Bytecode/BytecodeOpInterface.h" #include "mlir/IR/Dialect.h" #include "mlir/IR/OpImplementation.h" #include "mlir/Interfaces/InferTypeOpInterface.h"