diff --git a/clang/lib/AST/Interp/ByteCodeExprGen.cpp b/clang/lib/AST/Interp/ByteCodeExprGen.cpp --- a/clang/lib/AST/Interp/ByteCodeExprGen.cpp +++ b/clang/lib/AST/Interp/ByteCodeExprGen.cpp @@ -2536,7 +2536,8 @@ // This happens in C. if (!Ctx.getLangOpts().CPlusPlus) { if (const auto *VD = dyn_cast(D); - VD && VD->hasGlobalStorage() && VD->getAnyInitializer()) { + VD && VD->hasGlobalStorage() && VD->getAnyInitializer() && + VD->getType().isConstQualified()) { if (!this->visitVarDecl(VD)) return false; // Retry. diff --git a/clang/test/AST/Interp/c.c b/clang/test/AST/Interp/c.c --- a/clang/test/AST/Interp/c.c +++ b/clang/test/AST/Interp/c.c @@ -14,11 +14,15 @@ // pedantic-expected-warning {{not an integer constant expression}} _Static_assert(!!1, ""); -/// FIXME: Should also be rejected in the new interpreter -int a = (1 == 1 ? 5 : 3); +int a = (1 == 1 ? 5 : 3); // expected-note {{declared here}} \ + // pedantic-expected-note {{declared here}} _Static_assert(a == 5, ""); // ref-error {{not an integral constant expression}} \ // pedantic-ref-error {{not an integral constant expression}} \ - // pedantic-expected-warning {{not an integer constant expression}} + // expected-error {{not an integral constant expression}} \ + // expected-note {{read of non-const variable}} \ + // pedantic-expected-error {{not an integral constant expression}} \ + // pedantic-expected-note {{read of non-const variable}} + const int b = 3; _Static_assert(b == 3, ""); // pedantic-ref-warning {{not an integer constant expression}} \