diff --git a/libcxx/cmake/caches/Generic-no-unicode.cmake b/libcxx/cmake/caches/Generic-no-unicode.cmake --- a/libcxx/cmake/caches/Generic-no-unicode.cmake +++ b/libcxx/cmake/caches/Generic-no-unicode.cmake @@ -1 +1,2 @@ +set(LIBCXX_ENABLE_STD_MODULES ON CACHE BOOL "") # TODO MODULES Remove when enabled automatically. set(LIBCXX_ENABLE_UNICODE OFF CACHE BOOL "") diff --git a/libcxx/docs/Modules.rst b/libcxx/docs/Modules.rst --- a/libcxx/docs/Modules.rst +++ b/libcxx/docs/Modules.rst @@ -47,6 +47,7 @@ * ``LIBCXX_ENABLE_THREADS`` * ``LIBCXX_ENABLE_FILESYSTEM`` * ``LIBCXX_ENABLE_RANDOM_DEVICE`` + * ``LIBCXX_ENABLE_UNICODE`` Some of the current limitations ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/libcxx/modules/CMakeLists.txt.in b/libcxx/modules/CMakeLists.txt.in --- a/libcxx/modules/CMakeLists.txt.in +++ b/libcxx/modules/CMakeLists.txt.in @@ -29,9 +29,6 @@ endif() endmacro() -if(NOT @LIBCXX_ENABLE_UNICODE@) - message(FATAL_ERROR "Modules without Unicode support is not yet implemented.") -endif() if(NOT @LIBCXX_ENABLE_EXCEPTIONS@ OR NOT @LIBCXXABI_ENABLE_EXCEPTIONS@) message(FATAL_ERROR "Modules without exception support is not yet implemented.") endif() diff --git a/libcxx/modules/std/print.inc b/libcxx/modules/std/print.inc --- a/libcxx/modules/std/print.inc +++ b/libcxx/modules/std/print.inc @@ -13,5 +13,7 @@ using std::println; using std::vprint_nonunicode; +#ifndef _LIBCPP_HAS_NO_UNICODE using std::vprint_unicode; +#endif // _LIBCPP_HAS_NO_UNICODE } // namespace std diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml --- a/libcxx/utils/ci/buildkite-pipeline.yml +++ b/libcxx/utils/ci/buildkite-pipeline.yml @@ -653,8 +653,11 @@ - "**/test-results.xml" - "**/*.abilist" env: - CC: "clang-${LLVM_HEAD_VERSION}" - CXX: "clang++-${LLVM_HEAD_VERSION}" + # Note: Modules require and absolute path for clang-scan-deps + # https://github.com/llvm/llvm-project/issues/61006 + CC: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang" + CXX: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang++" + CMAKE: "/opt/bin/cmake" ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders"