diff --git a/libcxx/cmake/caches/Generic-module-std-cxx23.cmake b/libcxx/cmake/caches/Generic-module-std-cxx23.cmake deleted file mode 100644 --- a/libcxx/cmake/caches/Generic-module-std-cxx23.cmake +++ /dev/null @@ -1,4 +0,0 @@ -set(LIBCXX_ENABLE_STD_MODULES ON CACHE BOOL "") -set(LIBCXX_TEST_PARAMS "std=c++23" CACHE STRING "") -set(LIBCXXABI_TEST_PARAMS "std=c++23" CACHE STRING "") - diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml --- a/libcxx/utils/ci/buildkite-pipeline.yml +++ b/libcxx/utils/ci/buildkite-pipeline.yml @@ -149,27 +149,6 @@ limit: 2 timeout_in_minutes: 120 - - label: "C++23 Module std" - command: "libcxx/utils/ci/run-buildbot generic-module-std-cxx23" - artifact_paths: - - "**/test-results.xml" - - "**/*.abilist" - env: - # Note modules require and absolute path for clang-scan-deps - # https://github.com/llvm/llvm-project/issues/61006 - CC: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang" - CXX: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang++" - CMAKE: "/opt/bin/cmake" - ENABLE_CLANG_TIDY: "On" - agents: - queue: "libcxx-builders" - os: "linux" - retry: - automatic: - - exit_status: -1 # Agent was lost - limit: 2 - timeout_in_minutes: 120 - - label: "C++11" command: "libcxx/utils/ci/run-buildbot generic-cxx11" artifact_paths: @@ -217,9 +196,13 @@ - "**/test-results.xml" - "**/*.abilist" env: - CC: "clang-${LLVM_HEAD_VERSION}" - CXX: "clang++-${LLVM_HEAD_VERSION}" + # Note: Modules require and absolute path for clang-scan-deps + # https://github.com/llvm/llvm-project/issues/61006 + CC: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang" + CXX: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang++" + CMAKE: "/opt/bin/cmake" ENABLE_CLANG_TIDY: "On" + ENABLE_STD_MODULES: "On" agents: queue: "libcxx-builders" os: "linux" @@ -311,6 +294,7 @@ CC: "clang-15" CXX: "clang++-15" ENABLE_CLANG_TIDY: "On" + ENABLE_STD_MODULES: "Off" agents: queue: "libcxx-builders" os: "linux" @@ -329,6 +313,7 @@ CC: "clang-16" CXX: "clang++-16" ENABLE_CLANG_TIDY: "On" + ENABLE_STD_MODULES: "Off" agents: queue: "libcxx-builders" os: "linux" @@ -344,8 +329,11 @@ - "**/test-results.xml" - "**/*.abilist" env: - CC: "clang-17" - CXX: "clang++-17" + # Note: Modules require and absolute path for clang-scan-deps + # https://github.com/llvm/llvm-project/issues/61006 + CC: "/usr/lib/llvm-17/bin/clang" + CXX: "/usr/lib/llvm-17/bin/clang++" + CMAKE: "/opt/bin/cmake" ENABLE_CLANG_TIDY: "On" agents: queue: "libcxx-builders" @@ -1124,6 +1112,7 @@ env: CC: "clang15" CXX: "clang++15" + ENABLE_STD_MODULES: "Off" agents: queue: "libcxx-builders" os: "freebsd" diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot --- a/libcxx/utils/ci/run-buildbot +++ b/libcxx/utils/ci/run-buildbot @@ -51,6 +51,12 @@ ENABLE_CLANG_TIDY Whether to compile and run clang-tidy checks. This variable is optional. + +ENABLE_STD_MODULES Whether to enable or disable building the C++23 std + modules. This variable is optional. + TODO MODULES remove when all supported compilers support + modules. + EOF } @@ -119,6 +125,10 @@ ENABLE_CLANG_TIDY=Off fi +if [ -n "${ENABLE_STD_MODULES}" ]; then + ENABLE_STD_MODULES="-DLIBCXX_ENABLE_STD_MODULES=${ENABLE_STD_MODULES}" +fi + function generate-cmake-base() { echo "--- Generating CMake" ${CMAKE} \ @@ -131,6 +141,7 @@ -DLIBCXXABI_ENABLE_WERROR=YES \ -DLIBUNWIND_ENABLE_WERROR=YES \ -DLIBCXX_ENABLE_CLANG_TIDY=${ENABLE_CLANG_TIDY} \ + ${ENABLE_STD_MODULES} \ -DLLVM_LIT_ARGS="-sv --show-unsupported --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \ "${@}" } @@ -414,12 +425,6 @@ check-runtimes check-abi-list ;; -generic-module-std-cxx23) - clean - generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-module-std-cxx23.cmake" - check-runtimes - check-abi-list -;; # # Parts removed #