Page MenuHomePhabricator

[mips] Macros for [d]div[u],[d]rem[u]
AbandonedPublic

Authored by obucina on Dec 24 2015, 8:07 AM.

Details

Summary

Add support for missing macros for [d]div[u],[d]rem[u]

Diff Detail

Event Timeline

obucina updated this revision to Diff 43607.Dec 24 2015, 8:07 AM
obucina retitled this revision from to [mips] Macros for [d]div[u],[d]rem[u].
obucina updated this object.
obucina added reviewers: dsanders, zoran.jovanovic.
obucina added a subscriber: llvm-commits.
dsanders requested changes to this revision.Jan 12 2016, 6:49 AM
dsanders edited edge metadata.

The code for div and rem should be almost identical (one uses mflo, the other mfhi). Could you fold the duplicate implementations together?

Also, could you separate out the addition of the immediate cases from the addition of rem? Doing this in two patches will make it a bit easier to review.

This revision now requires changes to proceed.Jan 12 2016, 6:49 AM
obucina abandoned this revision.Feb 11 2016, 7:29 AM

This patch is split into three separate patches, and is now abandoned. Related patches:

http://reviews.llvm.org/D16888
http://reviews.llvm.org/D16889
http://reviews.llvm.org/D17036