Page MenuHomePhabricator

Make it possible to create common symbols from bitcode
ClosedPublic

Authored by rafael on Dec 24 2015, 6:54 AM.

Details

Reviewers
ruiu
grimar
Summary

Since the only missing bit was the size, I just replaced the Elf_Sym with the size.

We could go with DefinedCommon, DefinedCommonElf<ELFT> and DefinedCommonBitcode, but that seems a bit much.

Diff Detail

Event Timeline

rafael updated this revision to Diff 43600.Dec 24 2015, 6:54 AM
rafael retitled this revision from to Make it possible to create common symbols from bitcode.
rafael updated this object.
rafael added reviewers: ruiu, grimar.
rafael added a subscriber: llvm-commits.

Sending email since I forgot to add llvm-commits initially.

ruiu accepted this revision.Dec 24 2015, 7:24 AM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 24 2015, 7:24 AM
grimar accepted this revision.Dec 24 2015, 7:27 AM
grimar edited edge metadata.

LGTM with a nit

ELF/OutputSections.cpp
1376

I dont think we used const for auto anywhere in lld before.

rafael closed this revision.Dec 24 2015, 8:27 AM