Page MenuHomePhabricator

Rename OutputSection -> Segment.
Needs ReviewPublic

Authored by ruiu on Dec 23 2015, 6:07 PM.

Details

Reviewers
espindola
Summary

Segment is the official terminology in the ELF spec to denote
the output section. Segment is better than OutputSection since
it is shorter and less confusing than InputSection.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 43574.Dec 23 2015, 6:07 PM
ruiu retitled this revision from to Rename OutputSection -> Segment..
ruiu updated this object.
ruiu added a reviewer: rafael.
ruiu added a subscriber: llvm-commits.
rafael edited edge metadata.Dec 23 2015, 7:11 PM
rafael added a subscriber: rafael.

Unfortunately I don't think that is correct. The spec says


In the first phase, input sections that match in name, type and
attribute flags should be concatenated into single sections ...

In the second phase, sections should be assigned to segments or other

units based on their attribute flags ...

So our OutputSection is what the "single sections" refers to.

emaste added a subscriber: emaste.Dec 23 2015, 7:17 PM

Segment is the official terminology in the ELF spec to denote the output section.

This is confusing to me - the output ELF file has both sections and segments.

espindola edited reviewers, added: espindola; removed: rafael.Mar 15 2018, 10:56 AM