Page MenuHomePhabricator

Fix assert hit when tree-transforming template template parameter packs.
ClosedPublic

Authored by klimek on Dec 23 2015, 5:06 AM.

Event Timeline

klimek updated this revision to Diff 43523.Dec 23 2015, 5:06 AM
klimek retitled this revision from to Fix assert hit when tree-transforming template template parameter packs..
klimek updated this object.
klimek added a reviewer: rsmith.
klimek added a subscriber: cfe-commits.
dblaikie added inline comments.
test/SemaTemplate/temp_arg_template.cpp
80 ↗(On Diff #44451)

It would be good if we tested for some specific behavior here other than "don't crash" (doing anything other than crashing is a bit underspecified) - maybe we should be testing that N has the right value?

(don't have quite enough context on the fix itself to sign off on it though, unfortunately :/)

klimek updated this revision to Diff 44451.Jan 11 2016, 2:10 AM

Expand test.

klimek added inline comments.
test/SemaTemplate/temp_arg_template.cpp
80 ↗(On Diff #44451)

Done.

bkramer accepted this revision.Jan 11 2016, 3:35 AM
bkramer edited edge metadata.

This looks good. getAsTemplateOrTemplatePattern mirrors the existing switch in TreeTransform.

This revision is now accepted and ready to land.Jan 11 2016, 3:35 AM
This revision was automatically updated to reflect the committed changes.