diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp --- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp +++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp @@ -4654,12 +4654,19 @@ // ensures that when one input is a nan, the other will also be a nan allowing // the nan to propagate. If both inputs are nan, this will swap the inputs // which is harmless. - // FIXME: Handle nonans FMF and use isKnownNeverNaN. - SDValue XIsNonNan = DAG.getSetCC(DL, XLenVT, X, X, ISD::SETOEQ); - SDValue NewY = DAG.getSelect(DL, VT, XIsNonNan, Y, X); + // FIXME: Use isKnownNeverNaN. - SDValue YIsNonNan = DAG.getSetCC(DL, XLenVT, Y, Y, ISD::SETOEQ); - SDValue NewX = DAG.getSelect(DL, VT, YIsNonNan, X, Y); + SDValue NewX, NewY; + if (Op->getFlags().hasNoNaNs()) { + NewX = X; + NewY = Y; + } else { + SDValue XIsNonNan = DAG.getSetCC(DL, XLenVT, X, X, ISD::SETOEQ); + NewY = DAG.getSelect(DL, VT, XIsNonNan, Y, X); + + SDValue YIsNonNan = DAG.getSetCC(DL, XLenVT, Y, Y, ISD::SETOEQ); + NewX = DAG.getSelect(DL, VT, YIsNonNan, X, Y); + } unsigned Opc = Op.getOpcode() == ISD::FMAXIMUM ? RISCVISD::FMAX : RISCVISD::FMIN; diff --git a/llvm/test/CodeGen/RISCV/double-maximum-minimum.ll b/llvm/test/CodeGen/RISCV/double-maximum-minimum.ll --- a/llvm/test/CodeGen/RISCV/double-maximum-minimum.ll +++ b/llvm/test/CodeGen/RISCV/double-maximum-minimum.ll @@ -159,6 +159,73 @@ %1 = call double @llvm.maximum.f64(double %a, double %b) ret double %1 } + +define double @fminimum_nnan_f64(double %a, double %b) nounwind { +; CHECKIFD-LABEL: fminimum_nnan_f64: +; CHECKIFD: # %bb.0: +; CHECKIFD-NEXT: fmin.d fa0, fa0, fa1 +; CHECKIFD-NEXT: ret +; +; RV32IZFINXZDINX-LABEL: fminimum_nnan_f64: +; RV32IZFINXZDINX: # %bb.0: +; RV32IZFINXZDINX-NEXT: addi sp, sp, -16 +; RV32IZFINXZDINX-NEXT: sw a2, 8(sp) +; RV32IZFINXZDINX-NEXT: sw a3, 12(sp) +; RV32IZFINXZDINX-NEXT: lw a2, 8(sp) +; RV32IZFINXZDINX-NEXT: lw a3, 12(sp) +; RV32IZFINXZDINX-NEXT: sw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: sw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: lw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: lw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: fmin.d a0, a0, a2 +; RV32IZFINXZDINX-NEXT: sw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: sw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: lw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: lw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: addi sp, sp, 16 +; RV32IZFINXZDINX-NEXT: ret +; +; RV64IZFINXZDINX-LABEL: fminimum_nnan_f64: +; RV64IZFINXZDINX: # %bb.0: +; RV64IZFINXZDINX-NEXT: fmin.d a0, a0, a1 +; RV64IZFINXZDINX-NEXT: ret + %1 = call nnan double @llvm.minimum.f64(double %a, double %b) + ret double %1 +} + +define double @fmaximum_nnan_f64(double %a, double %b) nounwind { +; CHECKIFD-LABEL: fmaximum_nnan_f64: +; CHECKIFD: # %bb.0: +; CHECKIFD-NEXT: fmax.d fa0, fa0, fa1 +; CHECKIFD-NEXT: ret +; +; RV32IZFINXZDINX-LABEL: fmaximum_nnan_f64: +; RV32IZFINXZDINX: # %bb.0: +; RV32IZFINXZDINX-NEXT: addi sp, sp, -16 +; RV32IZFINXZDINX-NEXT: sw a2, 8(sp) +; RV32IZFINXZDINX-NEXT: sw a3, 12(sp) +; RV32IZFINXZDINX-NEXT: lw a2, 8(sp) +; RV32IZFINXZDINX-NEXT: lw a3, 12(sp) +; RV32IZFINXZDINX-NEXT: sw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: sw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: lw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: lw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: fmax.d a0, a0, a2 +; RV32IZFINXZDINX-NEXT: sw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: sw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: lw a0, 8(sp) +; RV32IZFINXZDINX-NEXT: lw a1, 12(sp) +; RV32IZFINXZDINX-NEXT: addi sp, sp, 16 +; RV32IZFINXZDINX-NEXT: ret +; +; RV64IZFINXZDINX-LABEL: fmaximum_nnan_f64: +; RV64IZFINXZDINX: # %bb.0: +; RV64IZFINXZDINX-NEXT: fmax.d a0, a0, a1 +; RV64IZFINXZDINX-NEXT: ret + %1 = call nnan double @llvm.maximum.f64(double %a, double %b) + ret double %1 +} + ;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line: ; RV32IFD: {{.*}} ; RV64IFD: {{.*}} diff --git a/llvm/test/CodeGen/RISCV/float-maximum-minimum.ll b/llvm/test/CodeGen/RISCV/float-maximum-minimum.ll --- a/llvm/test/CodeGen/RISCV/float-maximum-minimum.ll +++ b/llvm/test/CodeGen/RISCV/float-maximum-minimum.ll @@ -181,3 +181,51 @@ %1 = call float @llvm.maximum.f32(float %a, float %b) ret float %1 } + +define float @fminimum_nnan_f32(float %a, float %b) nounwind { +; RV32IF-LABEL: fminimum_nnan_f32: +; RV32IF: # %bb.0: +; RV32IF-NEXT: fmin.s fa0, fa0, fa1 +; RV32IF-NEXT: ret +; +; RV32IZFINX-LABEL: fminimum_nnan_f32: +; RV32IZFINX: # %bb.0: +; RV32IZFINX-NEXT: fmin.s a0, a0, a1 +; RV32IZFINX-NEXT: ret +; +; RV64IF-LABEL: fminimum_nnan_f32: +; RV64IF: # %bb.0: +; RV64IF-NEXT: fmin.s fa0, fa0, fa1 +; RV64IF-NEXT: ret +; +; RV64IZFINX-LABEL: fminimum_nnan_f32: +; RV64IZFINX: # %bb.0: +; RV64IZFINX-NEXT: fmin.s a0, a0, a1 +; RV64IZFINX-NEXT: ret + %1 = call nnan float @llvm.minimum.f32(float %a, float %b) + ret float %1 +} + +define float @fmaximum_nnan_f32(float %a, float %b) nounwind { +; RV32IF-LABEL: fmaximum_nnan_f32: +; RV32IF: # %bb.0: +; RV32IF-NEXT: fmax.s fa0, fa0, fa1 +; RV32IF-NEXT: ret +; +; RV32IZFINX-LABEL: fmaximum_nnan_f32: +; RV32IZFINX: # %bb.0: +; RV32IZFINX-NEXT: fmax.s a0, a0, a1 +; RV32IZFINX-NEXT: ret +; +; RV64IF-LABEL: fmaximum_nnan_f32: +; RV64IF: # %bb.0: +; RV64IF-NEXT: fmax.s fa0, fa0, fa1 +; RV64IF-NEXT: ret +; +; RV64IZFINX-LABEL: fmaximum_nnan_f32: +; RV64IZFINX: # %bb.0: +; RV64IZFINX-NEXT: fmax.s a0, a0, a1 +; RV64IZFINX-NEXT: ret + %1 = call nnan float @llvm.maximum.f32(float %a, float %b) + ret float %1 +} diff --git a/llvm/test/CodeGen/RISCV/half-maximum-minimum.ll b/llvm/test/CodeGen/RISCV/half-maximum-minimum.ll --- a/llvm/test/CodeGen/RISCV/half-maximum-minimum.ll +++ b/llvm/test/CodeGen/RISCV/half-maximum-minimum.ll @@ -99,3 +99,31 @@ %1 = call half @llvm.maximum.f16(half %a, half %b) ret half %1 } + +define half @fminimum_nnan_f16(half %a, half %b) nounwind { +; CHECKIZFH-LABEL: fminimum_nnan_f16: +; CHECKIZFH: # %bb.0: +; CHECKIZFH-NEXT: fmin.h fa0, fa0, fa1 +; CHECKIZFH-NEXT: ret +; +; CHECKIZHINX-LABEL: fminimum_nnan_f16: +; CHECKIZHINX: # %bb.0: +; CHECKIZHINX-NEXT: fmin.h a0, a0, a1 +; CHECKIZHINX-NEXT: ret + %1 = call nnan half @llvm.minimum.f16(half %a, half %b) + ret half %1 +} + +define half @fmaximum_nnan_f16(half %a, half %b) nounwind { +; CHECKIZFH-LABEL: fmaximum_nnan_f16: +; CHECKIZFH: # %bb.0: +; CHECKIZFH-NEXT: fmax.h fa0, fa0, fa1 +; CHECKIZFH-NEXT: ret +; +; CHECKIZHINX-LABEL: fmaximum_nnan_f16: +; CHECKIZHINX: # %bb.0: +; CHECKIZHINX-NEXT: fmax.h a0, a0, a1 +; CHECKIZHINX-NEXT: ret + %1 = call nnan half @llvm.maximum.f16(half %a, half %b) + ret half %1 +}