[libcxx] [test] Make set_windows_crt_report_mode.h more explicit

[mstorsjo]

Summary

This header is included when building with a debug CRT in
MSVC/Clang-cl environments. By default, failed asserts with the
debug CRT pops up a blocking dialog box alerting the user about
the failed assert. When running more than one test in an automated
fashion, this isn't ideal.

This header tries to run initializers to set the behaviour of the
failed asserts to print a message to the console, just like the
default is in release mode.

This is previously done by setting the reporting mode to
_CRTDBG_MODE_DEBUG, which means outputting to the debugger's
output window. In some setups, this is enough for making it work,
but in others it instead can pop up a dialog asking for which
debugger to use.

Instead set the mode explicitly to _CRTDBG_MODE_FILE and set the
destination to be explicitly to stderr.

For setups where the previous code worked correctly, it doesn't make
any difference other than that a failed assert prints an additional
"abort() has been called" message that wasn't printed before.

Patch originally by Andrew Ng.

[Mordante]

I'm not too familiar with this. When others more familiar with Windows are happy with it I'm happy to approve for libc++.

[andrewng]

LGTM, but then again I did author the originating patch, so perhaps someone else also needs to take a look?

[mstorsjo]

In D155823#4529184, @andrewng wrote:

LGTM, but then again I did author the originating patch, so perhaps someone else also needs to take a look?

Well I also looked at it, so that gives one author and one domain review, so I think that's quite enough.

[Mordante]

In D155823#4529386, @mstorsjo wrote:

In D155823#4529184, @andrewng wrote:

LGTM, but then again I did author the originating patch, so perhaps someone else also needs to take a look?

Well I also looked at it, so that gives one author and one domain review, so I think that's quite enough.

Agreed, so I'm happy to approve for libc++.

libcxx/test/support/set_windows_crt_report_mode.h

 
 #include <crtdbg.h>
 
 // On Windows in debug builds the default assertion handler opens a new dialog
 // window which must be dismissed manually by the user. This function overrides
 // that setting and instead changes the assertion handler to log to stderr
 // instead.
 inline int init_crt_report_mode() {
-  _CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_DEBUG);
-  _CrtSetReportMode(_CRT_ERROR, _CRTDBG_MODE_DEBUG);
-  _CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_DEBUG);
+  _CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_FILE);
+  _CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDERR);
+  _CrtSetReportMode(_CRT_ERROR, _CRTDBG_MODE_FILE);
+  _CrtSetReportFile(_CRT_ERROR, _CRTDBG_FILE_STDERR);
+  _CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_FILE);
+  _CrtSetReportFile(_CRT_ASSERT, _CRTDBG_FILE_STDERR);
   return 0;
 }
 
 static int init_crt_anchor = init_crt_report_mode();
 #endif // defined(__cplusplus) && __cplusplus > 199711L
 
 #endif // SUPPORT_SET_WINDOWS_CRT_REPORT_MODE_H