diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp --- a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp @@ -2978,34 +2978,48 @@ return nullptr; } -// (icmp eq X, 0) | (icmp ult Other, X) -> (icmp ule Other, X-1) -// (icmp ne X, 0) & (icmp uge Other, X) -> (icmp ugt Other, X-1) -static Value *foldAndOrOfICmpEqZeroAndICmp(ICmpInst *LHS, ICmpInst *RHS, - bool IsAnd, bool IsLogical, - IRBuilderBase &Builder) { +// (icmp eq X, C) | (icmp ult Other, (X - C)) -> (icmp ule Other, (X - (C + 1))) +// (icmp ne X, C) & (icmp uge Other, (X - C)) -> (icmp ugt Other, (X - (C + 1))) +static Value *foldAndOrOfICmpEqConstantAndICmp(ICmpInst *LHS, ICmpInst *RHS, + bool IsAnd, bool IsLogical, + IRBuilderBase &Builder) { + Value *LHS0 = LHS->getOperand(0); + Value *RHS0 = RHS->getOperand(0); + Value *RHS1 = RHS->getOperand(1); + ICmpInst::Predicate LPred = IsAnd ? LHS->getInversePredicate() : LHS->getPredicate(); ICmpInst::Predicate RPred = IsAnd ? RHS->getInversePredicate() : RHS->getPredicate(); - Value *LHS0 = LHS->getOperand(0); - if (LPred != ICmpInst::ICMP_EQ || !match(LHS->getOperand(1), m_Zero()) || + + const APInt *CInt; + if (LPred != ICmpInst::ICMP_EQ || !match(LHS->getOperand(1), m_APInt(CInt)) || !LHS0->getType()->isIntOrIntVectorTy() || !(LHS->hasOneUse() || RHS->hasOneUse())) return nullptr; + Constant *C = ConstantInt::get(LHS0->getType(), *CInt); + + auto MatchRHSOp = [LHS0, CInt](const Value *RHSOp) { + return match(RHSOp, m_Add(m_Specific(LHS0), m_SpecificInt(-*CInt))) || + (CInt->isZero() && RHSOp == LHS0); + }; + Value *Other; - if (RPred == ICmpInst::ICMP_ULT && RHS->getOperand(1) == LHS0) - Other = RHS->getOperand(0); - else if (RPred == ICmpInst::ICMP_UGT && RHS->getOperand(0) == LHS0) - Other = RHS->getOperand(1); + if (RPred == ICmpInst::ICMP_ULT && MatchRHSOp(RHS1)) + Other = RHS0; + else if (RPred == ICmpInst::ICMP_UGT && MatchRHSOp(RHS0)) + Other = RHS1; else return nullptr; if (IsLogical) Other = Builder.CreateFreeze(Other); + return Builder.CreateICmp( IsAnd ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_UGE, - Builder.CreateAdd(LHS0, Constant::getAllOnesValue(LHS0->getType())), + Builder.CreateSub( + LHS0, Builder.CreateAdd(C, ConstantInt::get(LHS0->getType(), 1))), Other); } @@ -3052,12 +3066,12 @@ return V; if (Value *V = - foldAndOrOfICmpEqZeroAndICmp(LHS, RHS, IsAnd, IsLogical, Builder)) + foldAndOrOfICmpEqConstantAndICmp(LHS, RHS, IsAnd, IsLogical, Builder)) return V; // We can treat logical like bitwise here, because both operands are used on // the LHS, and as such poison from both will propagate. - if (Value *V = foldAndOrOfICmpEqZeroAndICmp(RHS, LHS, IsAnd, - /*IsLogical*/ false, Builder)) + if (Value *V = foldAndOrOfICmpEqConstantAndICmp(RHS, LHS, IsAnd, + /*IsLogical*/ false, Builder)) return V; if (Value *V = diff --git a/llvm/test/Transforms/InstCombine/and-or-icmp-const-icmp.ll b/llvm/test/Transforms/InstCombine/and-or-icmp-const-icmp.ll --- a/llvm/test/Transforms/InstCombine/and-or-icmp-const-icmp.ll +++ b/llvm/test/Transforms/InstCombine/and-or-icmp-const-icmp.ll @@ -27,10 +27,8 @@ define i1 @eq_basic_equal_5(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @eq_basic_equal_5 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[SUB:%.*]] = add i8 [[X]], -5 -; CHECK-NEXT: [[C1:%.*]] = icmp eq i8 [[X]], 5 -; CHECK-NEXT: [[C2:%.*]] = icmp ugt i8 [[SUB]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or i1 [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add i8 [[X]], -6 +; CHECK-NEXT: [[OR:%.*]] = icmp uge i8 [[TMP1]], [[Y]] ; CHECK-NEXT: ret i1 [[OR]] ; %sub = sub i8 %x, 5 @@ -43,10 +41,7 @@ define i1 @eq_basic_equal_minus_1(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @eq_basic_equal_minus_1 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X]], 1 -; CHECK-NEXT: [[C1:%.*]] = icmp eq i8 [[X]], -1 -; CHECK-NEXT: [[C2:%.*]] = icmp ugt i8 [[ADD]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or i1 [[C1]], [[C2]] +; CHECK-NEXT: [[OR:%.*]] = icmp uge i8 [[X]], [[Y]] ; CHECK-NEXT: ret i1 [[OR]] ; %add = add i8 %x, 1 @@ -59,10 +54,8 @@ define i1 @eq_basic_equal_minus_7(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @eq_basic_equal_minus_7 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X]], 7 -; CHECK-NEXT: [[C1:%.*]] = icmp eq i8 [[X]], -7 -; CHECK-NEXT: [[C2:%.*]] = icmp ugt i8 [[ADD]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or i1 [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add i8 [[X]], 6 +; CHECK-NEXT: [[OR:%.*]] = icmp uge i8 [[TMP1]], [[Y]] ; CHECK-NEXT: ret i1 [[OR]] ; %add = add i8 %x, 7 @@ -158,10 +151,8 @@ define <2 x i1> @eq_vector_equal_5(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @eq_vector_equal_5 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[SUB:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp eq <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ugt <2 x i8> [[SUB]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add <2 x i8> [[X]], +; CHECK-NEXT: [[OR:%.*]] = icmp uge <2 x i8> [[TMP1]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[OR]] ; %sub = sub <2 x i8> %x, @@ -174,10 +165,7 @@ define <2 x i1> @eq_vector_equal_minus_1(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @eq_vector_equal_minus_1 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp eq <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ugt <2 x i8> [[ADD]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[OR:%.*]] = icmp uge <2 x i8> [[X]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[OR]] ; %add = add <2 x i8> %x, @@ -190,10 +178,8 @@ define <2 x i1> @eq_vector_equal_minus_7(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @eq_vector_equal_minus_7 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp eq <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ugt <2 x i8> [[ADD]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add <2 x i8> [[X]], +; CHECK-NEXT: [[OR:%.*]] = icmp uge <2 x i8> [[TMP1]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[OR]] ; %add = add <2 x i8> %x, @@ -254,10 +240,7 @@ define i1 @eq_commuted_equal_minus_1(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @eq_commuted_equal_minus_1 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X]], 1 -; CHECK-NEXT: [[C1:%.*]] = icmp eq i8 [[X]], -1 -; CHECK-NEXT: [[C2:%.*]] = icmp ugt i8 [[ADD]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or i1 [[C1]], [[C2]] +; CHECK-NEXT: [[OR:%.*]] = icmp uge i8 [[X]], [[Y]] ; CHECK-NEXT: ret i1 [[OR]] ; %add = add i8 %x, 1 @@ -283,10 +266,7 @@ define <2 x i1> @eq_vetor_commuted_equal_minus_1(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @eq_vetor_commuted_equal_minus_1 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp eq <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ugt <2 x i8> [[ADD]], [[Y]] -; CHECK-NEXT: [[OR:%.*]] = or <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[OR:%.*]] = icmp uge <2 x i8> [[X]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[OR]] ; %add = add <2 x i8> %x, @@ -319,10 +299,8 @@ define i1 @ne_basic_equal_5(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @ne_basic_equal_5 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[SUB:%.*]] = add i8 [[X]], -5 -; CHECK-NEXT: [[C1:%.*]] = icmp ne i8 [[X]], 5 -; CHECK-NEXT: [[C2:%.*]] = icmp ule i8 [[SUB]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and i1 [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add i8 [[X]], -6 +; CHECK-NEXT: [[AND:%.*]] = icmp ult i8 [[TMP1]], [[Y]] ; CHECK-NEXT: ret i1 [[AND]] ; %sub = sub i8 %x, 5 @@ -335,10 +313,7 @@ define i1 @ne_basic_equal_minus_1(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @ne_basic_equal_minus_1 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X]], 1 -; CHECK-NEXT: [[C1:%.*]] = icmp ne i8 [[X]], -1 -; CHECK-NEXT: [[C2:%.*]] = icmp ule i8 [[ADD]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and i1 [[C1]], [[C2]] +; CHECK-NEXT: [[AND:%.*]] = icmp ult i8 [[X]], [[Y]] ; CHECK-NEXT: ret i1 [[AND]] ; %add = add i8 %x, 1 @@ -351,10 +326,8 @@ define i1 @ne_basic_equal_minus_7(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @ne_basic_equal_minus_7 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X]], 7 -; CHECK-NEXT: [[C1:%.*]] = icmp ne i8 [[X]], -7 -; CHECK-NEXT: [[C2:%.*]] = icmp ule i8 [[ADD]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and i1 [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add i8 [[X]], 6 +; CHECK-NEXT: [[AND:%.*]] = icmp ult i8 [[TMP1]], [[Y]] ; CHECK-NEXT: ret i1 [[AND]] ; %add = add i8 %x, 7 @@ -450,10 +423,8 @@ define <2 x i1> @ne_vector_equal_5(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @ne_vector_equal_5 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[SUB:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp ne <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ule <2 x i8> [[SUB]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add <2 x i8> [[X]], +; CHECK-NEXT: [[AND:%.*]] = icmp ult <2 x i8> [[TMP1]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[AND]] ; %sub = sub <2 x i8> %x, @@ -466,10 +437,7 @@ define <2 x i1> @ne_vector_equal_minus_1(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @ne_vector_equal_minus_1 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp ne <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ule <2 x i8> [[ADD]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[AND:%.*]] = icmp ult <2 x i8> [[X]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[AND]] ; %add = add <2 x i8> %x, @@ -482,10 +450,8 @@ define <2 x i1> @ne_vector_equal_minus_7(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @ne_vector_equal_minus_7 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp ne <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ule <2 x i8> [[ADD]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[TMP1:%.*]] = add <2 x i8> [[X]], +; CHECK-NEXT: [[AND:%.*]] = icmp ult <2 x i8> [[TMP1]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[AND]] ; %add = add <2 x i8> %x, @@ -546,10 +512,7 @@ define i1 @ne_commuted_equal_minus_1(i8 %x, i8 %y) { ; CHECK-LABEL: define i1 @ne_commuted_equal_minus_1 ; CHECK-SAME: (i8 [[X:%.*]], i8 [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X]], 1 -; CHECK-NEXT: [[C1:%.*]] = icmp ne i8 [[X]], -1 -; CHECK-NEXT: [[C2:%.*]] = icmp ule i8 [[ADD]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and i1 [[C1]], [[C2]] +; CHECK-NEXT: [[AND:%.*]] = icmp ult i8 [[X]], [[Y]] ; CHECK-NEXT: ret i1 [[AND]] ; %add = add i8 %x, 1 @@ -575,10 +538,7 @@ define <2 x i1> @ne_vetor_commuted_equal_minus_1(<2 x i8> %x, <2 x i8> %y) { ; CHECK-LABEL: define <2 x i1> @ne_vetor_commuted_equal_minus_1 ; CHECK-SAME: (<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) { -; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X]], -; CHECK-NEXT: [[C1:%.*]] = icmp ne <2 x i8> [[X]], -; CHECK-NEXT: [[C2:%.*]] = icmp ule <2 x i8> [[ADD]], [[Y]] -; CHECK-NEXT: [[AND:%.*]] = and <2 x i1> [[C1]], [[C2]] +; CHECK-NEXT: [[AND:%.*]] = icmp ult <2 x i8> [[X]], [[Y]] ; CHECK-NEXT: ret <2 x i1> [[AND]] ; %add = add <2 x i8> %x,