Page MenuHomePhabricator

Remove hardcoded registers from Hexagon ABI
ClosedPublic

Authored by ted on Dec 11 2015, 10:23 AM.

Details

Summary

The Hexagon ABI plugin uses hardcoded registers when setting up function calls. This is OK for the Hexagon simulator, but the register numbers are different on the gdbserver running on hardware. Change the hardcoded registers to LLDB generic registers.

Diff Detail

Event Timeline

ted updated this revision to Diff 42540.Dec 11 2015, 10:23 AM
ted retitled this revision from to Remove hardcoded registers from Hexagon ABI.
ted updated this object.
ted added a reviewer: clayborg.
ted added a subscriber: lldb-commits.
clayborg requested changes to this revision.Dec 11 2015, 10:44 AM
clayborg edited edge metadata.

You want to check if each reg num is not LLDB_INVALID_REGNUM and return an appropriate error.

This revision now requires changes to proceed.Dec 11 2015, 10:44 AM
ted updated this revision to Diff 42555.Dec 11 2015, 12:05 PM
ted edited edge metadata.

Updated to check for invalid register numbers.

clayborg accepted this revision.Dec 11 2015, 12:54 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2015, 12:54 PM
ted closed this revision.Dec 11 2015, 1:55 PM