diff --git a/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp b/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp --- a/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp +++ b/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp @@ -29,7 +29,7 @@ static Value createI32Constant(ConversionPatternRewriter &rewriter, Location loc, int32_t value) { Type llvmI32 = rewriter.getI32Type(); - return rewriter.createOrFold(loc, llvmI32, value); + return rewriter.create(loc, llvmI32, value); } namespace { @@ -317,14 +317,14 @@ return input; int64_t numBytes = vectorType.getNumElements(); Type destType = rewriter.getIntegerType(numBytes * 8); - Value result = rewriter.createOrFold( + Value result = rewriter.create( loc, destType, rewriter.getIntegerAttr(destType, 0)); for (int64_t i = 0; i < numBytes; ++i) { Value idxConst = createI32Constant(rewriter, loc, i); Value element = rewriter.create(loc, input, idxConst); Value extended = rewriter.create(loc, destType, element); - Value shiftConst = rewriter.createOrFold( + Value shiftConst = rewriter.create( loc, destType, rewriter.getIntegerAttr(destType, i * 8)); Value shifted = rewriter.create(loc, extended, shiftConst); result = rewriter.create(loc, result, shifted); diff --git a/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp b/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp --- a/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp +++ b/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp @@ -62,9 +62,7 @@ for (int i = 0; i < memrefType.getRank(); ++i) { if (!memrefType.isDynamicDim(i)) continue; - Value size = rewriter.createOrFold(loc, i); - Value dim = - rewriter.createOrFold(loc, op.getInput(), size); + Value dim = rewriter.createOrFold(loc, op.getInput(), i); dynamicOperands.push_back(dim); } diff --git a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp --- a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp +++ b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp @@ -2124,8 +2124,8 @@ affineDimsExpr(rewriter, 0, 1, 2)}); // Width and height dimensions of the original input. - auto dimH = linalg::createOrFoldDimOp(rewriter, loc, input, 1); - auto dimW = linalg::createOrFoldDimOp(rewriter, loc, input, 2); + auto dimH = rewriter.createOrFold(loc, input, 1); + auto dimW = rewriter.createOrFold(loc, input, 2); // Constants and dimension sizes auto twoPiAttr = rewriter.getFloatAttr(elementType, 6.283185307179586); diff --git a/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp b/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp --- a/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp +++ b/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp @@ -71,8 +71,7 @@ for (int i = 0; i < destType.getRank(); ++i) { if (destType.getShape()[i] != ShapedType::kDynamic) continue; - auto index = b.createOrFold(loc, i); - Value size = b.create(loc, value, index); + Value size = b.create(loc, value, i); dynamicOperands.push_back(size); } // TODO: Use alloc/memcpy callback from BufferizationOptions if called via diff --git a/mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp b/mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp --- a/mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp +++ b/mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp @@ -51,8 +51,7 @@ ubs.reserve(lbs.size()); steps.reserve(lbs.size()); for (auto idx = 0; idx < rank; ++idx) { - ubs.push_back(b.createOrFold( - from, b.create(idx))); + ubs.push_back(b.createOrFold(from, idx)); steps.push_back(one); } diff --git a/mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp b/mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp --- a/mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp +++ b/mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp @@ -59,11 +59,11 @@ auto staticBufferType = MemRefType::get(width * cst.value(), b.getIntegerType(8)); if (options.useAlloca) { - return b.createOrFold(staticBufferType, ValueRange{}, - alignmentAttr); + return b.create(staticBufferType, ValueRange{}, + alignmentAttr); } - return b.createOrFold(staticBufferType, ValueRange{}, - alignmentAttr); + return b.create(staticBufferType, ValueRange{}, + alignmentAttr); } // Fallback dynamic buffer. @@ -86,8 +86,8 @@ std::optional alignment, DataLayout &layout) { ShapedType viewType = subView.getType(); ImplicitLocOpBuilder b(subView.getLoc(), builder); - auto zero = b.createOrFold(0); - auto one = b.createOrFold(1); + auto zero = b.create(0); + auto one = b.create(1); Value allocSize = one; for (const auto &size : llvm::enumerate(boundingSubViewSize)) diff --git a/mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp b/mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp --- a/mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp +++ b/mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp @@ -68,7 +68,7 @@ Location loc = dimOp->getLoc(); rewriter.replaceOpWithNewOp( dimOp, resultShape, - rewriter.createOrFold(loc, *dimIndex)); + rewriter.create(loc, *dimIndex).getResult()); return success(); } };