Page MenuHomePhabricator

Enable half2float() on windows.
ClosedPublic

Authored by ADodds on Dec 8 2015, 6:19 AM.

Details

Summary

This function was disabled for the windows build by Virgil in part of this patch:
http://llvm.org/klaus/lldb/commit/fdf8273428eab9e111ce6b319a9bcf5547ffb5b1/

I have tested this code on VS2013 (Update4) and VS2015 and it builds ok.
I dont want to enable this and break anyones build however.

Is anyone using an older version of VisualStudio (that perhaps doesnt support this function)?

Diff Detail

Repository
rL LLVM

Event Timeline

ADodds updated this revision to Diff 42167.Dec 8 2015, 6:19 AM
ADodds retitled this revision from to Enable half2float() on windows..
ADodds updated this object.
ADodds added reviewers: amccarth, zturner.
ADodds set the repository for this revision to rL LLVM.
ADodds added a subscriber: xen2.
zturner edited edge metadata.Dec 8 2015, 8:10 AM
zturner added a subscriber: zturner.

This should be fine on any version of MSVC. Not sure why it was disabled
for MSVC to begin with. ldexpf() was new with VS 2010, but the last time a
compiler older than VS 2010 was supported was a really long time ago.

In any case, VS 2013 is the minimum required version now, and VS 2015 will
be the minimum required version soon. So lgtm.

ADodds edited edge metadata.Dec 9 2015, 1:44 AM
ADodds added a subscriber: lldb-commits.
ADodds added a comment.Dec 9 2015, 9:03 AM

If there are no objections, are you happy to accept this?

zturner accepted this revision.Dec 9 2015, 9:59 AM
zturner edited edge metadata.

Yea, sorry. In the future if someone says "lgtm" that's as good as hitting the accept button in phabricator.

This revision is now accepted and ready to land.Dec 9 2015, 9:59 AM
This revision was automatically updated to reflect the committed changes.