diff --git a/bolt/lib/Core/BinaryContext.cpp b/bolt/lib/Core/BinaryContext.cpp --- a/bolt/lib/Core/BinaryContext.cpp +++ b/bolt/lib/Core/BinaryContext.cpp @@ -1760,10 +1760,10 @@ } MarkerSymType BinaryContext::getMarkerType(const SymbolRef &Symbol) const { - // For aarch64, the ABI defines mapping symbols so we identify data in the - // code section (see IHI0056B). $x identifies a symbol starting code or the - // end of a data chunk inside code, $d indentifies start of data. - if (!isAArch64() || ELFSymbolRef(Symbol).getSize()) + // For aarch64 and riscv, the ABI defines mapping symbols so we identify data + // in the code section (see IHI0056B). $x identifies a symbol starting code or + // the end of a data chunk inside code, $d indentifies start of data. + if ((!isAArch64() && !isRISCV()) || ELFSymbolRef(Symbol).getSize()) return MarkerSymType::NONE; Expected NameOrError = Symbol.getName(); diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp --- a/bolt/lib/Rewrite/RewriteInstance.cpp +++ b/bolt/lib/Rewrite/RewriteInstance.cpp @@ -881,7 +881,7 @@ } }; - if (BC->isAArch64()) { + if (BC->isAArch64() || BC->isRISCV()) { addExtraDataMarkerPerSymbol(SortedFileSymbols, SortedMarkerSymbols); LastSymbol = std::stable_partition( SortedFileSymbols.begin(), SortedFileSymbols.end(), diff --git a/bolt/test/RISCV/mapping-syms.s b/bolt/test/RISCV/mapping-syms.s new file mode 100644 --- /dev/null +++ b/bolt/test/RISCV/mapping-syms.s @@ -0,0 +1,27 @@ +/// FIXME llvm-mc is used instead of clang because we need a recent change in +/// the RISC-V MC layer (D153260). Once that one is released, we can switch to +/// clang. (Note that the pre-merge check buildbots use the system's clang). +// RUN: llvm-mc -triple riscv64 -mattr=+c -filetype obj -o %t.o %s +// RUN: ld.lld -o %t %t.o +// RUN: llvm-bolt --print-cfg --print-only=_start -o %t.bolt %t 2>&1 | FileCheck %s +// RUN: llvm-objdump -d %t.bolt | FileCheck --check-prefix=CHECK-OBJDUMP %s + +// CHECK-NOT: BOLT-WARNING + +/// Check that .word is not disassembled by BOLT +// CHECK: 00000000: nop +// CHECK: 00000002: ret + +/// Check .word is still present in output +// CHECK-OBJDUMP: <_start>: +// CHECK-OBJDUMP-NEXT: nop +// CHECK-OBJDUMP-NEXT: unimp +// CHECK-OBJDUMP-NEXT: unimp +// CHECK-OBJDUMP-NEXT: ret + .text + .globl _start + .p2align 1 +_start: + nop + .word 0x0 + ret