diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp --- a/lld/ELF/Writer.cpp +++ b/lld/ELF/Writer.cpp @@ -251,6 +251,14 @@ ElfSym::edata2 = add("_edata", -1); } +static OutputSection *findSection(uint32_t type, unsigned partition = 1) { + for (SectionCommand *cmd : script->sectionCommands) + if (auto *osd = dyn_cast(cmd)) + if (osd->osec.type == type && osd->osec.partition == partition) + return &osd->osec; + return nullptr; +} + static OutputSection *findSection(StringRef name, unsigned partition = 1) { for (SectionCommand *cmd : script->sectionCommands) if (auto *osd = dyn_cast(cmd)) @@ -2418,6 +2426,10 @@ note = nullptr; } } + + if (config->emachine == EM_RISCV) + if (OutputSection *cmd = findSection(PT_RISCV_ATTRIBUTES, partNo)) + addHdr(PT_RISCV_ATTRIBUTES, PF_R)->add(cmd); return ret; } diff --git a/lld/docs/ReleaseNotes.rst b/lld/docs/ReleaseNotes.rst --- a/lld/docs/ReleaseNotes.rst +++ b/lld/docs/ReleaseNotes.rst @@ -28,6 +28,7 @@ * ``--remap-inputs=`` and ``--remap-inputs-file=`` are added to remap input files. (`D148859 `_) +* ``PT_RISCV_ATTRIBUTES`` is added to include the SHT_RISCV_ATTRIBUTES section. Breaking changes ---------------- diff --git a/lld/test/ELF/riscv-attributes.s b/lld/test/ELF/riscv-attributes.s --- a/lld/test/ELF/riscv-attributes.s +++ b/lld/test/ELF/riscv-attributes.s @@ -3,7 +3,7 @@ # RUN: rm -rf %t && split-file %s %t && cd %t # RUN: llvm-mc -filetype=obj -triple=riscv64 a.s -o a.o # RUN: ld.lld -e 0 a.o -o out 2>&1 | count 0 -# RUN: llvm-readobj --arch-specific out | FileCheck %s +# RUN: llvm-readelf -S -l --arch-specific out | FileCheck %s --check-prefixes=PHDR,CHECK # RUN: ld.lld -e 0 a.o a.o -o out1 2>&1 | count 0 # RUN: llvm-readobj --arch-specific out1 | FileCheck %s # RUN: ld.lld -r a.o a.o -o out1 2>&1 | count 0 @@ -63,6 +63,14 @@ # UNKNOWN22-COUNT-2: warning: unknown22.o:(.riscv.attributes): invalid tag 0x16 at offset 0x10 # UNKNOWN22: warning: unknown22a.o:(.riscv.attributes): invalid tag 0x16 at offset 0x10 +# HDR: Name Type Address Off Size ES Flg Lk Inf Al +# HDR: .riscv.attributes RISCV_ATTRIBUTES 0000000000000000 000158 00003e 00 0 0 1{{$}} + +# HDR: Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align +# HDR: LOAD 0x000000 0x0000000000010000 0x0000000000010000 0x000158 0x000158 R 0x1000 +# HDR-NEXT: GNU_STACK 0x000000 0x0000000000000000 0x0000000000000000 0x000000 0x000000 RW 0 +# HDR-NEXT: ATTRIBUTES 0x000158 0x0000000000000000 0x0000000000000000 0x00003e 0x00003e R 0x1{{$}} + # CHECK: BuildAttributes { # CHECK-NEXT: FormatVersion: 0x41 # CHECK-NEXT: Section 1 {