Index: llvm/lib/Analysis/InstructionSimplify.cpp =================================================================== --- llvm/lib/Analysis/InstructionSimplify.cpp +++ llvm/lib/Analysis/InstructionSimplify.cpp @@ -218,12 +218,6 @@ // Arguments and constants dominate all instructions. return true; - // If we are processing instructions (and/or basic blocks) that have not been - // fully added to a function, the parent nodes may still be null. Simply - // return the conservative answer in these cases. - if (!I->getParent() || !P->getParent() || !I->getFunction()) - return false; - // If we have a DominatorTree then do a precise test. if (DT) return DT->dominates(I, P); @@ -2638,7 +2632,7 @@ // that might be resolve lazily to symbols in another dynamically-loaded // library (and, thus, could be malloc'ed by the implementation). if (const AllocaInst *AI = dyn_cast(V)) - return AI->getParent() && AI->getFunction() && AI->isStaticAlloca(); + return AI->isStaticAlloca(); if (const GlobalValue *GV = dyn_cast(V)) return (GV->hasLocalLinkage() || GV->hasHiddenVisibility() || GV->hasProtectedVisibility() || GV->hasGlobalUnnamedAddr()) && @@ -3669,7 +3663,7 @@ Value *LHS, Value *RHS, const SimplifyQuery &Q) { // Gracefully handle instructions that have not been inserted yet. - if (!Q.AC || !Q.CxtI || !Q.CxtI->getParent()) + if (!Q.AC || !Q.CxtI) return nullptr; for (Value *AssumeBaseOp : {LHS, RHS}) { @@ -6480,9 +6474,6 @@ if (!NumOperands) { switch (IID) { case Intrinsic::vscale: { - // Call may not be inserted into the IR yet at point of calling simplify. - if (!Call->getParent() || !Call->getParent()->getParent()) - return nullptr; auto Attr = Call->getFunction()->getFnAttribute(Attribute::VScaleRange); if (!Attr.isValid()) return nullptr; @@ -6930,10 +6921,7 @@ // Replace the instruction with its simplified value. I->replaceAllUsesWith(SimpleV); - // Gracefully handle edge cases where the instruction is not wired into any - // parent block. - if (I->getParent() && !I->isEHPad() && !I->isTerminator() && - !I->mayHaveSideEffects()) + if (!I->isEHPad() && !I->isTerminator() && !I->mayHaveSideEffects()) I->eraseFromParent(); } else { Worklist.insert(I); @@ -6962,10 +6950,7 @@ // Replace the instruction with its simplified value. I->replaceAllUsesWith(SimpleV); - // Gracefully handle edge cases where the instruction is not wired into any - // parent block. - if (I->getParent() && !I->isEHPad() && !I->isTerminator() && - !I->mayHaveSideEffects()) + if (!I->isEHPad() && !I->isTerminator() && !I->mayHaveSideEffects()) I->eraseFromParent(); } return Simplified;