diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp --- a/clang/lib/Sema/SemaInit.cpp +++ b/clang/lib/Sema/SemaInit.cpp @@ -15,6 +15,7 @@ #include "clang/AST/ExprCXX.h" #include "clang/AST/ExprObjC.h" #include "clang/AST/ExprOpenMP.h" +#include "clang/AST/IgnoreExpr.h" #include "clang/AST/TypeLoc.h" #include "clang/Basic/CharInfo.h" #include "clang/Basic/SourceManager.h" @@ -170,22 +171,9 @@ while (true) { E->setType(Ty); E->setValueKind(VK_PRValue); - if (isa(E) || isa(E)) { - break; - } else if (ParenExpr *PE = dyn_cast(E)) { - E = PE->getSubExpr(); - } else if (UnaryOperator *UO = dyn_cast(E)) { - assert(UO->getOpcode() == UO_Extension); - E = UO->getSubExpr(); - } else if (GenericSelectionExpr *GSE = dyn_cast(E)) { - E = GSE->getResultExpr(); - } else if (ChooseExpr *CE = dyn_cast(E)) { - E = CE->getChosenSubExpr(); - } else if (PredefinedExpr *PE = dyn_cast(E)) { - E = PE->getFunctionName(); - } else { - llvm_unreachable("unexpected expr in string literal init"); - } + if (isa(E) || isa(E)) + break; + E = IgnoreParensSingleStep(E); } } @@ -194,20 +182,9 @@ static void updateGNUCompoundLiteralRValue(Expr *E) { while (true) { E->setValueKind(VK_PRValue); - if (isa(E)) { - break; - } else if (ParenExpr *PE = dyn_cast(E)) { - E = PE->getSubExpr(); - } else if (UnaryOperator *UO = dyn_cast(E)) { - assert(UO->getOpcode() == UO_Extension); - E = UO->getSubExpr(); - } else if (GenericSelectionExpr *GSE = dyn_cast(E)) { - E = GSE->getResultExpr(); - } else if (ChooseExpr *CE = dyn_cast(E)) { - E = CE->getChosenSubExpr(); - } else { - llvm_unreachable("unexpected expr in array compound literal init"); - } + if (isa(E)) + break; + E = IgnoreParensSingleStep(E); } }