This is an archive of the discontinued LLVM Phabricator instance.

Avoid pointless canonicalize when using Dwarf names
ClosedPublic

Authored by marksantaniello on May 25 2023, 6:48 AM.

Details

Summary

CPU profile indicated memcmp was hot due to the two rfind calls in
getCanonicalFnName. If UseSymbolTable is false, we can avoid the cost entirely.

For CSSPGO profiles I've measured ~5% speedup with this change.

Profile similarity before/after matches 100%.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 6:48 AM
Herald added subscribers: hoy, wlei. · View Herald Transcript
marksantaniello requested review of this revision.May 25 2023, 6:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 6:48 AM
marksantaniello edited the summary of this revision. (Show Details)May 25 2023, 6:51 AM
marksantaniello added reviewers: wenlei, hoy.
wenlei accepted this revision.May 25 2023, 7:35 AM

lgtm, thanks for the fix.

This revision is now accepted and ready to land.May 25 2023, 7:35 AM
This revision was landed with ongoing or failed builds.May 25 2023, 8:15 AM
This revision was automatically updated to reflect the committed changes.