diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp --- a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp +++ b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp @@ -751,10 +751,8 @@ attr.getValue() .cast() .getAsValueRange(); - // Convert IteratorType enums into the string representation. This is - // needed, because tests still use the old format when 'iterator_types' - // attribute is represented as an array of strings. - // TODO: Remove this conversion once tests are fixed. + // Convert IteratorType enums into the string representation. Iterator + // types are printed as an array of string for legacy reasons. SmallVector iteratorTypeNames = llvm::to_vector(llvm::map_range( iteratorTypes, [&](utils::IteratorType t) -> Attribute { @@ -813,10 +811,8 @@ result.attributes.assign(dictAttr.getValue().begin(), dictAttr.getValue().end()); - // Convert array of string into an array of IteratorType enums. This is - // needed, because tests still use the old format when 'iterator_types' - // attribute is represented as an array of strings. - // TODO: Remove this conversion once tests are fixed. + // Convert array of string into an array of IteratorType. Iterator + // types are printed as an array of string for legacy reasons. auto iteratorTypes = dyn_cast_or_null( result.attributes.get(getIteratorTypesAttrName(result.name))); if (!iteratorTypes) { diff --git a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp --- a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp +++ b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp @@ -655,10 +655,8 @@ result.attributes.append(dictAttr.getValue().begin(), dictAttr.getValue().end()); - // Convert array of string into an array of IteratyType enums. This is needed, - // because tests still use the old format when 'iterator_types' attribute is - // represented as an array of strings. - // TODO: Remove this conversion once tests are fixed. + // Convert array of string into an array of IteratorType. Iterator + // types are printed as an array of string for legacy reasons. ArrayAttr iteratorTypes = result.attributes.get(getIteratorTypesAttrName(result.name)) .cast(); @@ -710,10 +708,8 @@ attr.getValue() .cast() .getAsValueRange(); - // Convert IteratorType enums into the string representation. This is - // needed, because tests still use the old format when 'iterator_types' - // attribute is represented as an array of strings. - // TODO: Remove this conversion once tests are fixed. + // Convert IteratorType enums into the string representation. Iterator + // types are printed as an array of string for legacy reasons. SmallVector iteratorTypeNames = llvm::to_vector( llvm::map_range(iteratorTypes, [&](IteratorType t) -> Attribute { return StringAttr::get(getContext(), stringifyIteratorType(t));