diff --git a/llvm/include/llvm/MC/MCParser/MCAsmParser.h b/llvm/include/llvm/MC/MCParser/MCAsmParser.h --- a/llvm/include/llvm/MC/MCParser/MCAsmParser.h +++ b/llvm/include/llvm/MC/MCParser/MCAsmParser.h @@ -236,7 +236,7 @@ bool printPendingErrors() { bool rv = !PendingErrors.empty(); - for (auto Err : PendingErrors) { + for (auto &Err : PendingErrors) { printError(Err.Loc, Twine(Err.Msg), Err.Range); } PendingErrors.clear(); diff --git a/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp b/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp --- a/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp +++ b/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp @@ -1312,7 +1312,7 @@ return; auto TransRange = EntryValTransfers.equal_range(TRInst); - for (auto TDPair : llvm::make_range(TransRange.first, TransRange.second)) { + for (auto &TDPair : llvm::make_range(TransRange.first, TransRange.second)) { const VarLoc &EmittedEV = VarLocIDs[TDPair.second]; if (std::tie(EntryVL.Var, EntryVL.Locs[0].Value.RegNo, EntryVL.Expr) == std::tie(EmittedEV.Var, EmittedEV.Locs[0].Value.RegNo, diff --git a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp --- a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp +++ b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp @@ -402,7 +402,7 @@ MachineFunction &MF = PFS.MF; SMDiagnostic Error; const LLVMTargetMachine &TM = MF.getTarget(); - for (auto YamlCSInfo : YamlMF.CallSitesInfo) { + for (auto &YamlCSInfo : YamlMF.CallSitesInfo) { yaml::CallSiteInfo::MachineInstrLoc MILoc = YamlCSInfo.CallLocation; if (MILoc.BlockNum >= MF.size()) return error(Twine(MF.getName()) + diff --git a/llvm/lib/ObjectYAML/MachOEmitter.cpp b/llvm/lib/ObjectYAML/MachOEmitter.cpp --- a/llvm/lib/ObjectYAML/MachOEmitter.cpp +++ b/llvm/lib/ObjectYAML/MachOEmitter.cpp @@ -426,7 +426,7 @@ void MachOWriter::writeBindOpcodes( raw_ostream &OS, std::vector &BindOpcodes) { - for (auto Opcode : BindOpcodes) { + for (auto &Opcode : BindOpcodes) { uint8_t OpByte = Opcode.Opcode | Opcode.Imm; OS.write(reinterpret_cast(&OpByte), 1); for (auto Data : Opcode.ULEBExtraData) { diff --git a/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp b/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp --- a/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp +++ b/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp @@ -733,7 +733,7 @@ NewInstrID = SubBuilder.allocInstrID(); GIMatchTreeBuilder::LeafVec &NewLeaves = SubBuilder.getPossibleLeaves(); - for (const auto I : zip(NewLeaves, TraversedEdgesByNewLeaves)) { + for (const auto &I : zip(NewLeaves, TraversedEdgesByNewLeaves)) { auto &Leaf = std::get<0>(I); auto &TraversedEdgesForLeaf = std::get<1>(I); GIMatchTreeInstrInfo *InstrInfo = Leaf.getInstrInfo(InstrID);