diff --git a/llvm/lib/MC/MCObjectStreamer.cpp b/llvm/lib/MC/MCObjectStreamer.cpp --- a/llvm/lib/MC/MCObjectStreamer.cpp +++ b/llvm/lib/MC/MCObjectStreamer.cpp @@ -541,12 +541,6 @@ return; } const MCExpr *AddrDelta = buildSymbolDiff(*this, Label, LastLabel); - int64_t Res; - if (AddrDelta->evaluateAsAbsolute(Res, getAssemblerPtr())) { - MCDwarfLineAddr::Emit(this, Assembler->getDWARFLinetableParams(), LineDelta, - Res); - return; - } insert(new MCDwarfLineAddrFragment(LineDelta, *AddrDelta)); } @@ -571,14 +565,7 @@ void MCObjectStreamer::emitDwarfAdvanceFrameAddr(const MCSymbol *LastLabel, const MCSymbol *Label) { const MCExpr *AddrDelta = buildSymbolDiff(*this, Label, LastLabel); - int64_t Res; - if (AddrDelta->evaluateAsAbsolute(Res, getAssemblerPtr())) { - SmallString<8> Tmp; - MCDwarfFrameEmitter::encodeAdvanceLoc(getContext(), Res, Tmp); - emitBytes(Tmp); - } else { - insert(new MCDwarfCallFrameFragment(*AddrDelta)); - } + insert(new MCDwarfCallFrameFragment(*AddrDelta)); } void MCObjectStreamer::emitCVLocDirective(unsigned FunctionId, unsigned FileNo, diff --git a/llvm/test/MC/ELF/RISCV/gen-dwarf.s b/llvm/test/MC/ELF/RISCV/gen-dwarf.s new file mode 100644 --- /dev/null +++ b/llvm/test/MC/ELF/RISCV/gen-dwarf.s @@ -0,0 +1,97 @@ +## Linker relaxation imposes restrictions on .eh_frame/.debug_frame, .debug_line, +## and LEB128 uses. + +## CFI instructions can be preceded by relaxable instructions. We must use +## DW_CFA_advance_loc* opcodes with relocations. + +## For .debug_line, emit DW_LNS_fixed_advance_pc with ADD16/SUB16 relocations so +## that .debug_line can be fixed by the linker. Without linker relaxation, we can +## emit special opcodes to make .debug_line smaller, but we don't do this for +## consistency. + +# RUN: llvm-mc -filetype=obj -triple=riscv64 -g -dwarf-version=5 -mattr=+relax < %s -o %t +# RUN: llvm-dwarfdump -eh-frame -debug-line -debug-rnglists -v %t | FileCheck %s +# RUN: llvm-readobj -r %t | FileCheck %s --check-prefix=RELOC + +# CHECK: FDE +# CHECK-NEXT: Format: DWARF32 +# CHECK-NEXT: DW_CFA_advance_loc: 16 +# CHECK-NEXT: DW_CFA_def_cfa_offset: +32 +# CHECK-NEXT: DW_CFA_advance_loc: 4 +# CHECK-NEXT: DW_CFA_offset: X1 -8 +# CHECK-NEXT: DW_CFA_nop: + +# CHECK: DW_LNE_set_address +# CHECK-NEXT: DW_LNS_advance_line ([[#]]) +# CHECK-NEXT: DW_LNS_copy +# CHECK-NEXT: is_stmt +# CHECK-NEXT: DW_LNS_advance_line +# CHECK-NEXT: DW_LNS_fixed_advance_pc (0x0004) +# CHECK-NEXT: DW_LNS_copy +# CHECK-NEXT: is_stmt +# CHECK-NEXT: DW_LNS_advance_line +# CHECK-NEXT: DW_LNS_fixed_advance_pc (0x0004) +# CHECK-NEXT: DW_LNS_copy + +# CHECK: 0x00000000: range list header: length = 0x0000001d, format = DWARF32, version = 0x0005 +# CHECK-NEXT: ranges: +# CHECK-NEXT: 0x0000000c: [DW_RLE_start_length]: 0x0000000000000000, 0x0000000000000034 +# CHECK-NEXT: 0x00000016: [DW_RLE_start_length]: 0x0000000000000000, 0x0000000000000004 +# CHECK-NEXT: 0x00000020: [DW_RLE_end_of_list ] + +# RELOC: Section ([[#]]) .rela.eh_frame { +# RELOC-NEXT: 0x1C R_RISCV_32_PCREL - 0x0 +# RELOC-NEXT: 0x20 R_RISCV_ADD32 - 0x0 +# RELOC-NEXT: 0x20 R_RISCV_SUB32 - 0x0 +# RELOC-NEXT: 0x25 R_RISCV_SET6 - 0x0 +# RELOC-NEXT: 0x25 R_RISCV_SUB6 - 0x0 +# RELOC-NEXT: 0x28 R_RISCV_SET6 - 0x0 +# RELOC-NEXT: 0x28 R_RISCV_SUB6 - 0x0 +# RELOC-NEXT: 0x34 R_RISCV_32_PCREL - 0x0 +# RELOC-NEXT: 0x38 R_RISCV_ADD32 - 0x0 +# RELOC-NEXT: 0x38 R_RISCV_SUB32 - 0x0 +# RELOC-NEXT: } + +## TODO A section needs two relocations. +# RELOC: Section ([[#]]) .rela.debug_rnglists { +# RELOC-NEXT: 0xD R_RISCV_64 .text.foo 0x0 +# RELOC-NEXT: 0x17 R_RISCV_64 .text.bar 0x0 +# RELOC-NEXT: } + +# RELOC: Section ([[#]]) .rela.debug_line { +# RELOC: R_RISCV_ADD16 - 0x0 +# RELOC-NEXT: R_RISCV_SUB16 - 0x0 +# RELOC-NEXT: R_RISCV_ADD16 - 0x0 +# RELOC-NEXT: R_RISCV_SUB16 - 0x0 +# RELOC-NEXT: R_RISCV_ADD16 - 0x0 +# RELOC-NEXT: R_RISCV_SUB16 - 0x0 +# RELOC: } + +.section .text.foo,"ax" +.globl foo +foo: +.cfi_startproc +.Lpcrel_hi0: + auipc a1, %pcrel_hi(g) + lw a1, %pcrel_lo(.Lpcrel_hi0)(a1) + bge a1, a0, .LBB0_2 + addi sp, sp, -32 + .cfi_def_cfa_offset 32 + sd ra, 24(sp) + .cfi_offset ra, -8 + addi a0, sp, 8 + call ext@plt + ld ra, 24(sp) + addi sp, sp, 32 + ret +.LBB0_2: + li a0, 0 + ret + .cfi_endproc + .size foo, .-foo + +.section .text.bar,"ax" +bar: +.cfi_startproc + nop +.cfi_endproc diff --git a/llvm/test/MC/ELF/RISCV/lit.local.cfg b/llvm/test/MC/ELF/RISCV/lit.local.cfg new file mode 100644 --- /dev/null +++ b/llvm/test/MC/ELF/RISCV/lit.local.cfg @@ -0,0 +1,2 @@ +if 'RISCV' not in config.root.targets: + config.unsupported = True