diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td --- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td +++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td @@ -52,6 +52,7 @@ let hasOperationAttrVerify = 1; let hasRegionArgAttrVerify = 1; let hasRegionResultAttrVerify = 1; + let usePropertiesForAttributes = 1; let extraClassDeclaration = [{ void registerAttributes(); diff --git a/mlir/test/Dialect/SPIRV/IR/memory-ops.mlir b/mlir/test/Dialect/SPIRV/IR/memory-ops.mlir --- a/mlir/test/Dialect/SPIRV/IR/memory-ops.mlir +++ b/mlir/test/Dialect/SPIRV/IR/memory-ops.mlir @@ -321,15 +321,6 @@ // ----- -func.func @load_unknown_memory_access() -> () { - %0 = spirv.Variable : !spirv.ptr - // expected-error @+1 {{failed to satisfy constraint: valid SPIR-V MemoryAccess}} - %1 = "spirv.Load"(%0) {memory_access = 0x80000000 : i32} : (!spirv.ptr) -> (f32) - return -} - -// ----- - func.func @aligned_load_incorrect_attributes() -> () { %0 = spirv.Variable : !spirv.ptr // expected-error @+1 {{expected ']'}}