diff --git a/clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsCheck.cpp --- a/clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsCheck.cpp @@ -17,13 +17,21 @@ namespace clang::tidy::bugprone { +static llvm::APFloat getHalf(const llvm::fltSemantics &Semantics) { + return llvm::APFloat(Semantics, 1U) / llvm::APFloat(Semantics, 2U); +} + namespace { AST_MATCHER(FloatingLiteral, floatHalf) { const auto &Literal = Node.getValue(); - if ((&Node.getSemantics()) == &llvm::APFloat::IEEEsingle()) - return Literal.convertToFloat() == 0.5f; - if ((&Node.getSemantics()) == &llvm::APFloat::IEEEdouble()) - return Literal.convertToDouble() == 0.5; + if ((&Node.getSemantics()) == &llvm::APFloat::IEEEsingle()) { + static llvm::APFloat Half = getHalf(llvm::APFloat::IEEEsingle()); + return Literal == Half; + } + if ((&Node.getSemantics()) == &llvm::APFloat::IEEEdouble()) { + static llvm::APFloat Half = getHalf(llvm::APFloat::IEEEdouble()); + return Literal == Half; + } return false; } } // namespace