diff --git a/clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp b/clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp --- a/clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp @@ -262,7 +262,10 @@ expr(anyOf(allOf(isMacroExpansion(), unless(isNULLMacroExpansion())), has(ignoringImplicit( memberExpr(hasDeclaration(fieldDecl(hasBitWidth(1)))))), - hasParent(explicitCastExpr()))); + hasParent(explicitCastExpr()), + expr(hasType(qualType().bind("type")), + hasParent(initListExpr(hasParent(explicitCastExpr( + hasType(qualType(equalsBoundNode("type")))))))))); auto ImplicitCastFromBool = implicitCastExpr( anyOf(hasCastKind(CK_IntegralCast), hasCastKind(CK_IntegralToFloating), // Prior to C++11 cast from bool literal to pointer was allowed. @@ -290,7 +293,7 @@ unless(ExceptionCases), unless(has(BoolXor)), // Retrieve also parent statement, to check if we need // additional parens in replacement. - anyOf(hasParent(stmt().bind("parentStmt")), anything()), + optionally(hasParent(stmt().bind("parentStmt"))), unless(isInTemplateInstantiation()), unless(hasAncestor(functionTemplateDecl()))) .bind("implicitCastToBool")), diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -237,6 +237,10 @@ behavior of using `i` as the prefix for enum tags, set the `EnumConstantPrefix` option to `i` instead of using `EnumConstantHungarianPrefix`. +- Fixed a false positive in :doc:`readability-implicit-bool-conversion + ` check warning would + be unnecessarily emitted for explicit cast using direct list initialization. + - Added support to optionally ignore user-defined literals in :doc:`readability-magic-numbers`. diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion.cpp --- a/clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion.cpp @@ -471,3 +471,10 @@ } } // namespace ignore_1bit_bitfields + +namespace PR47000 { + int to_int(bool x) { return int{x}; } + + using IntType = int; + int to_int2(bool x) { return IntType{x}; } +}