diff --git a/llvm/tools/dsymutil/Options.td b/llvm/tools/dsymutil/Options.td --- a/llvm/tools/dsymutil/Options.td +++ b/llvm/tools/dsymutil/Options.td @@ -169,7 +169,7 @@ def reproducer: Separate<["--", "-"], "reproducer">, MetaVarName<"">, - HelpText<"Specify the reproducer generation mode. Valid options are 'GenerateOnExit', 'GenerateOnCrash', 'Use', 'Off'.">, + HelpText<"Specify the reproducer generation mode. Valid options are 'GenerateOnExit', 'GenerateOnCrash', 'Off'.">, Group; def: Joined<["--", "-"], "reproducer=">, Alias; @@ -179,7 +179,7 @@ def use_reproducer: Separate<["--", "-"], "use-reproducer">, MetaVarName<"">, - HelpText<"Use the object files from the given reproducer path. Alias for --reproducer=Use.">, + HelpText<"Use the object files from the given reproducer path.">, Group; def: Joined<["--", "-"], "use-reproducer=">, Alias; diff --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp --- a/llvm/tools/dsymutil/dsymutil.cpp +++ b/llvm/tools/dsymutil/dsymutil.cpp @@ -250,14 +250,12 @@ return ReproducerMode::GenerateOnExit; if (S == "GenerateOnCrash") return ReproducerMode::GenerateOnCrash; - if (S == "Use") - return ReproducerMode::Use; if (S == "Off") return ReproducerMode::Off; return make_error( "invalid reproducer mode: '" + S + "'. Supported values are 'GenerateOnExit', 'GenerateOnCrash', " - "'Use', 'Off'.", + "'Off'.", inconvertibleErrorCode()); } return ReproducerMode::GenerateOnCrash; @@ -613,7 +611,7 @@ auto OptionsOrErr = getOptions(Args); if (!OptionsOrErr) { - WithColor::error() << toString(OptionsOrErr.takeError()); + WithColor::error() << toString(OptionsOrErr.takeError()) << '\n'; return EXIT_FAILURE; } @@ -627,7 +625,7 @@ auto Repro = Reproducer::createReproducer(Options.ReproMode, Options.ReproducerPath, argc, argv); if (!Repro) { - WithColor::error() << toString(Repro.takeError()); + WithColor::error() << toString(Repro.takeError()) << '\n'; return EXIT_FAILURE; }