diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp @@ -68,7 +68,7 @@ private: bool HandleModuleRemark(const clang::Diagnostic &info); - void SetCurrentModuleProgress(llvm::StringRef module_name); + void SetCurrentModuleProgress(std::string module_name); typedef std::pair IDAndDiagnostic; @@ -208,8 +208,9 @@ if (m_module_build_stack.empty()) { m_current_progress_up = nullptr; } else { - // Update the progress to re-show the module that was currently being - // built from the time the now completed module was originally began. + // When the just completed module began building, a module that depends on + // it ("module A") was effectively paused. Update the progress to re-show + // "module A" as continuing to be built. const auto &resumed_module_name = m_module_build_stack.back(); SetCurrentModuleProgress(resumed_module_name); } @@ -224,13 +225,12 @@ } void StoringDiagnosticConsumer::SetCurrentModuleProgress( - llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the existing progress event. - // 2. Beginining a new progress event. - m_current_progress_up = nullptr; - m_current_progress_up = std::make_unique( - llvm::formatv("Currently building module {0}", module_name)); + std::string module_name) { + if (!m_current_progress_up) + m_current_progress_up = + std::make_unique("Building Clang modules"); + + m_current_progress_up->Increment(1, std::move(module_name)); } ClangModulesDeclVendor::ClangModulesDeclVendor() diff --git a/lldb/test/API/functionalities/progress_reporting/clang_modules/TestClangModuleBuildProgress.py b/lldb/test/API/functionalities/progress_reporting/clang_modules/TestClangModuleBuildProgress.py --- a/lldb/test/API/functionalities/progress_reporting/clang_modules/TestClangModuleBuildProgress.py +++ b/lldb/test/API/functionalities/progress_reporting/clang_modules/TestClangModuleBuildProgress.py @@ -43,4 +43,4 @@ event = lldbutil.fetch_next_event(self, listener, broadcaster) payload = lldb.SBDebugger.GetProgressFromEvent(event) message = payload[0] - self.assertEqual(message, "Currently building module MyModule") + self.assertEqual(message, "Building Clang modules")